3.2.1-beta.4 on 0.4.7f6: game crashes right after load when a plain custom NPC exists (InitializeNPC on already initialized NPC, coreclr 0xc0000005)

[madjagstudios]

Follow-up to #309 (closed). Thanks for the quick beta.3/beta.4 fixes. Construction now works, but the game hard-crashes right after load whenever a plain custom contact exists. Same two-contact minimal repro as in #309, nothing else installed.

Environment: Schedule I 0.4.7f6 (Steam build 25439817), IL2CPP, MelonLoader 0.7.3, S1API 3.2.1-beta.4 (S1API.Il2Cpp.MelonLoader.dll SHA-256 bc0f6f35…0588), S1MAPI 2.0.0, and the two-contact repro mod from #309. No other mods.

What happens:

1. Both contacts construct and register. Right after load, the repro mod logs NPC.Get("repro_legacy_contact") → PRESENT and NPC.Get("repro_modern_contact") → PRESENT. No Failed to instantiate warnings.
2. About a second later the process dies. The MelonLoader log just ends. Player.log ends with:

Game loaded
  ScheduleOne.Persistence.<<StartGame>g__LoadRoutine|0>d:MoveNext()
InitializeNPC called on already initialized NPC. First deinitializing...
  ScheduleOne.NPCs.NPC:InitializeNPC(NPCData)
  ScheduleOne.NPCs.NPC:Awake_UserLogic_ScheduleOne.NPCs.NPC_Assembly-CSharp.dll()
  ScheduleOne.NPCs.NPC:Awake()

3. Windows Application log: coreclr.dll 6.0.3624.51421, exception 0xc0000005, fault offset 0x1d4089, followed by .NET Runtime 1023 "terminated due to an internal error in the .NET Runtime". No Unity crash dump.

Control: with the repro mod removed (S1API beta.4 alone), the same save loads fine.

Reading of it (not verified): a custom contact's GameObject gets activated after load, NPC.Awake calls InitializeNPC on an NPC that S1API already initialized during construction, the game deinitializes it first, and something managed then touches the deinitialized state. That would be a CoreCLR access violation under Il2CppInterop rather than a Unity native crash. The IL2CPP f6 validation may have registered the contacts without staying in-world past the first post-load Awake.

The full MelonLoader log and the Player.log tail are available if useful. Happy to test a fix build.

[ifBars]

Reproduced this on the same 0.4.7f6 IL2CPP build with the two-contact repro. Both contacts registered, then beta.4 exited with 0xc0000005 after the duplicate InitializeNPC warning. The older smoke test stopped right after registration, so it missed that later Awake. PR #317 fixes the handoff: both contacts now initialize once and stay alive in-game through a 15-second post-load check. It targets beta so this can go into beta.5 with #316. Thanks for the detailed crash trail.

[ifBars]

The fix is now out in 3.2.1-beta.5. I checked the DLLs from the published ZIP on 0.4.7f6: both custom contacts register and stay playable after load on Mono and IL2CPP, with no repeat InitializeNPC crash. Thanks again for the clear report.