Repository navigation
fix: support plain custom NPCs on f6 beta - #311
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ConsumeProductBehaviour.onConsumeDonemember before initializing it.Closes #309 after this reaches a beta release. The published 3.2.1-beta.3 still fails on f6; see the issue update.
Reproduction and validation
Used isolated 0.4.7f6 installs: Steam build 25439857 (Mono) and 25439817 (IL2CPP). The released beta.3 package fails both legacy constructor and
ConfigurePrefabcontacts after loading a save, with missingonConsumeDonemember errors. With this patch, the same live smoke reportsPASS|legacy=issue309_legacy|modern=issue309_modern|scene=Mainon both runtimes.Compatibility
No public or protected S1API symbols, durable IDs, save data, or network formats change. Older game builds retain initialization of the legacy UnityEvent. The f6 build skips it because the native member is absent. The old-build branch was not rerun in-game for this follow-up; beta.3 had passed f5 Mono and IL2CPP smoke before this change.