Skip to content

[tests] refactor the pipeline-level attention processor tests - #14701

Merged
sayakpaul merged 9 commits into
mainfrom
attn-fusion-tests
Oct 5, 2026
Merged

sayakpaul merged 9 commits into
mainfrom
attn-fusion-tests

Conversation

@sayakpaul

@sayakpaul sayakpaul commented Sep 4, 2026 •

Copy link
Copy Markdown
Member

Currently, we have got a bunch of QKV fusion tests for pipelines, but these tests don't exercise any pipeline-level features at all.

On the other hand, we have got a handful of QKV fusion tests in the model-level attention test suite. So, this PR removes these pipeline-level tests and adds to the existing model-level QKV fusion tests so that we can retain coverage.

Fixes #14255

@github-actions github-actions Bot added size/L PR with diff > 200 LOC tests labels Sep 4, 2026
Comment thread tests/models/testing_utils/attention.py Outdated
@sayakpaul

Copy link
Copy Markdown
Member Author

/diffusers-bot pytest tests/models -m attention -k test_fuse_unfuse_qkv_projections

@sayakpaul
sayakpaul marked this pull request as ready for review September 4, 2026 05:55
@github-actions

github-actions Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

✅ pytest tests/models -m attention -k test_fuse_unfuse_qkv_projections passed on GPU — view logs.

@sayakpaul
sayakpaul requested a review from DN6 September 4, 2026 06:17
@sayakpaul

Copy link
Copy Markdown
Member Author

@DN6 a gentle ping.

@sayakpaul sayakpaul added this to the Release 0.41.0 milestone Sep 30, 2026
@sayakpaul
sayakpaul merged commit c2798cc into main Oct 5, 2026
30 of 31 checks passed
@sayakpaul
sayakpaul deleted the attn-fusion-tests branch October 5, 2026 10:08
mingyi456 added a commit to mingyi456/diffusers that referenced this pull request Oct 6, 2026
* 'main' of https://github.com/huggingface/diffusers:
  [tests] remove `test_pipelines_common.py` (huggingface#14669)
  [chore] remove force_upcast from autoencoder flux2 (huggingface#14946)
  Configure fixed sampling sigmas on QwenImage21Pipeline (huggingface#14950)
  [tests] refactor the pipeline-level attention processor tests (huggingface#14701)
  [modular] Echo team joy future academy jd echo by @Gelercatty (huggingface#14941)
  Fix: Deprecating Siglip2ImageProcessorFast (huggingface#14781)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fixes-issue size/L PR with diff > 200 LOC tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[tests] migrate all attention processor related stuff from pipeline to model-level testing

2 participants