Skip to content

fix: remove dead sidebar-left toggle from v2 titlebar #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeonghun-jj-lee merged 1 commit into from
Aug 7, 2026
Merged

fix: remove dead sidebar-left toggle from v2 titlebar #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 5 additions & 15 deletions packages/app/src/components/titlebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,21 +404,11 @@ export function Titlebar(props: { update?: TitlebarUpdate; debugTools?: { visibl
aria-pressed={layout.route().type === "home"}
/>
</TooltipV2>
{/* amicode(workbench S1): the sessions-panel toggle, v2 titlebar
edition — the legacy grid-branch button never rendered here,
so the panel had no affordance (S1.4 probe). sidebar-LEFT:
this one drives the left sessions panel. */}
<IconButtonV2
type="button"
variant="ghost-muted"
size="large"
class="!w-9 shrink-0"
icon={<IconV2 name="sidebar-left" />}
state={layout.sidebar.opened() ? "pressed" : undefined}
onClick={() => layout.sidebar.toggle()}
aria-label={language.t("command.sidebar.toggle")}
aria-expanded={layout.sidebar.opened()}
/>
{/* Removed: sidebar-left toggle button (harmoniqs/amicode#265).
The button called layout.sidebar.toggle() but no component in
NewLayout observes that signal — WorkbenchPanel only mounts in
the legacy SplitFrame path. Re-add here when WorkbenchPanel is
ported to layout-new.tsx. */}

<div
class="flex min-w-0 flex-row items-center gap-1.5 overflow-x-auto no-scrollbar [app-region:no-drag]"
Expand Down
Loading