fix: remove dead sidebar-left toggle from v2 titlebar - #134
Merged
Conversation
The IconButtonV2 calling layout.sidebar.toggle() had no consumer in NewLayout — WorkbenchPanel only mounts in the legacy SplitFrame path. The button flipped a boolean no active component observed. Leave a comment for re-addition when WorkbenchPanel is ported to layout-new.tsx. Closes harmoniqs/amicode#265
jeonghun-jj-lee
marked this pull request as ready for review
August 7, 2026 20:09
jeonghun-jj-lee
added a commit
that referenced
this pull request
Aug 7, 2026
The button called layout.sidebar.toggle() but no component in NewLayout observes that signal — WorkbenchPanel only mounts in the legacy SplitFrame path. Re-add when WorkbenchPanel is ported to layout-new.tsx. Ref: harmoniqs/amicode#265 (same fix as PR #134, re-applied after rebase)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
sidebar-leftIconButtonV2from the v2 titlebar. The button calledlayout.sidebar.toggle()but no component inNewLayoutobserves that signal —WorkbenchPanelonly mounts in the legacySplitFramepath. The button flipped a boolean no active component observed.A comment at the removal site references the issue and notes re-addition when
WorkbenchPanelis ported tolayout-new.tsx.Acceptance Criteria
sidebar-leftIconButtonV2no longer renders in the v2 titlebarlayout-new.tsx<Match when>fallback in the<Switch>still renders its own sidebar toggle)typecheck+vite buildpass)Closes harmoniqs/amicode#265