fix(onboarding): retire always-written Bedrock placeholder, heal planted entries - #604
Merged
Conversation
…ted entries (#602) The always-written amazon-bedrock config entry (#455 as implemented in #589) shipped an unauthenticated placeholder key. Because a config- declared key outranks the auth-store key in the provider loader, the placeholder masked users' working Bedrock credentials — every prompt failed with 'Invalid API Key format: Base64 decoding failed'. - writeBatchConfig / writeOnboardingConfig: bedrock is written only when the user selects it with a valid key; always-write retired - writeOnboardingConfig: heal planted placeholder entries on next write (exact-match on the planted constant; real keys, including internal env-override entries, are never healed) - getBedrockServiceKey and its env override removed - #455 suites flipped from 'bedrock always present' to 'bedrock absent unless selected' + heal/preserve cases
6 tasks
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jeonghun-jj-lee
marked this pull request as ready for review
August 27, 2026 16:11
jeonghun-jj-lee
deleted the
602-fixextension-onboarding-writes-unauthenticated-bedrock-placeholder-that-masks-real-credentials
branch
August 27, 2026 16:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #602
Summary
Retires the always-written
amazon-bedrockconfig entry (#455 as implemented in #589), whose placeholder key masked users' working Bedrock credentials behindForbidden: Invalid API Key format: Base64 decoding failed.What changed
writeBatchConfig,writeOnboardingConfig): Bedrock is written only when the user explicitly selects it with a valid key. The always-write behavior and thegetBedrockServiceKeyhelper (both copies) are removed.writeOnboardingConfig, the merge path): a planted placeholder entry is dropped during the merge — exact-match on the planted constant, so entries written via the retired internal env override (real keys) are never healed. The batch path heals via its existing replace-on-redo semantics.Verification
typecheck: cleantest:smokefails identically onmain(pre-existing local port/auth collision, unrelated — documented here so it isn't attributed to this diff)Test plan