fix(onboarding): write-only-selected providers + always provision bedrock (#455) - #589
Merged
Conversation
…rock (#455) - credential_scanner: add bedrock service credential helper and unconditional bedrock infra entry in writeBatchConfig (with placeholder rejection via isValidApiKey already present); provider map now includes amazon-bedrock env var - onboarding_panel: writeOnboardingConfig always provisions bedrock (even on placeholder/invalid key early return); confirm-import handler now opt-in (empty includedProviders defaults to empty set) and always calls writeBatchConfig so bedrock is provisioned even with zero user providers - onboarding_webview: remove auto-check on test pass — checkboxes stay opt-in, only enable radio; user must explicitly check to import - tests: update redo-overwrite test to expect bedrock infra still present; add phantom-provider regression tests for batch + manual paths (only selected + bedrock, empty selection, placeholder rejection)
7 tasks
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
aarontrowbridge
marked this pull request as ready for review
August 27, 2026 11:59
aarontrowbridge
deleted the
455-bug-onboarding-writes-phantom-provider-entries-opencode-zen-anthropic-without-user-selection-2
branch
August 27, 2026 11:59
jeonghun-jj-lee
added a commit
that referenced
this pull request
Aug 27, 2026
…ted entries (#602) The always-written amazon-bedrock config entry (#455 as implemented in #589) shipped an unauthenticated placeholder key. Because a config- declared key outranks the auth-store key in the provider loader, the placeholder masked users' working Bedrock credentials — every prompt failed with 'Invalid API Key format: Base64 decoding failed'. - writeBatchConfig / writeOnboardingConfig: bedrock is written only when the user selects it with a valid key; always-write retired - writeOnboardingConfig: heal planted placeholder entries on next write (exact-match on the planted constant; real keys, including internal env-override entries, are never healed) - getBedrockServiceKey and its env override removed - #455 suites flipped from 'bedrock always present' to 'bedrock absent unless selected' + heal/preserve cases
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #455 — phantom provider entries (OpenCode Zen, Anthropic placeholder) are no longer written unless user explicitly selects them. Bedrock infra is always provisioned.
Changes
credential_scanner.ts:writeBatchConfignow always addsamazon-bedrockwith service credential (AMICO_BEDROCK_KEY or ABSK- placeholder) and rejects placeholder keys viaisValidApiKey; added bedrock to PROVIDER_ENV_VAR map.onboarding_panel.ts:writeOnboardingConfigalways provisions bedrock (even on invalid-key early return);confirm-importhandler is now pure opt-in (emptyincludedProviders=> empty set) and always callswriteBatchConfigso bedrock lands even with zero user providers.onboarding_webview.ts: on test pass, no longer auto-checks checkbox — checkboxes stay opt-in, only radio enabled; user must explicitly check.credential_scanner.test.ts: updated redo test to expect bedrock still present; added 5 regression tests verifying only-selected+bedrock, empty selection, placeholder rejection, manual path.Verification
pnpm typecheckgreenpnpm --filter ./packages/extension test: 1592 passed, 3 pre-existing failures (chat_bridge, terminal) unchanged; 88/88 onboarding+scanner tests greenAC coverage
Related: #449