Skip to content

perf(set): one-pass Set algebra — close the ~10x MRI gap #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannevaled merged 1 commit into from
Jun 30, 2026
Merged

perf(set): one-pass Set algebra — close the ~10x MRI gap #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ require (
github.com/go-ruby-rexml/rexml v0.0.0-20260629154021-5fb0f287ee8b
github.com/go-ruby-scanf/scanf v0.0.0-20260629150220-414dbb31c386
github.com/go-ruby-securerandom/securerandom v0.0.0-20260630081933-3f81ff7d7fb0
github.com/go-ruby-set/set v0.0.0-20260629145249-d3b3639f5a12
github.com/go-ruby-set/set v0.0.0-20260630204346-ab6a8a92a910
github.com/go-ruby-shellwords/shellwords v0.0.0-20260629114104-e941e4210818
github.com/go-ruby-strscan/strscan v0.0.0-20260630060240-10bd95a9c4a4
github.com/go-ruby-tsort/tsort v0.0.0-20260629151245-27c44f985c8b
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ github.com/go-ruby-scanf/scanf v0.0.0-20260629150220-414dbb31c386 h1:mt488Km0GMk
github.com/go-ruby-scanf/scanf v0.0.0-20260629150220-414dbb31c386/go.mod h1:UpBHz/Hf4Q8h14UpfJ5Cpp+OxVEqqNuICXGnUjg2dKc=
github.com/go-ruby-securerandom/securerandom v0.0.0-20260630081933-3f81ff7d7fb0 h1:NDJ7mJ3uMoysAoBRMJJNr0RRbqLfzp+8flALEeOuahI=
github.com/go-ruby-securerandom/securerandom v0.0.0-20260630081933-3f81ff7d7fb0/go.mod h1:xjx6gnzA3xXHkJrJFQDp1pW559J3kJR2e6GPctYg4K4=
github.com/go-ruby-set/set v0.0.0-20260629145249-d3b3639f5a12 h1:c051SI5P7BVVbysSroIJIZWwvXo9dZhWZlx9ef62xVI=
github.com/go-ruby-set/set v0.0.0-20260629145249-d3b3639f5a12/go.mod h1:F/P0PXeE5ybEPeWYfb1JAKWny1Li3dnlm6YxG2/vffE=
github.com/go-ruby-set/set v0.0.0-20260630204346-ab6a8a92a910 h1:Q41u365suJ1TlrX2mlVHOGBmW904Lwh3mo+WnlVPtno=
github.com/go-ruby-set/set v0.0.0-20260630204346-ab6a8a92a910/go.mod h1:F/P0PXeE5ybEPeWYfb1JAKWny1Li3dnlm6YxG2/vffE=
github.com/go-ruby-shellwords/shellwords v0.0.0-20260629114104-e941e4210818 h1:z9b99kWJht8AgtlIbdiq7Y02j6eddxW+rr4MJpCS6kw=
github.com/go-ruby-shellwords/shellwords v0.0.0-20260629114104-e941e4210818/go.mod h1:gJ+9ba+y8+DKenwjZKbTLVSuX6Xp7V5R7pZ6NwtD6x0=
github.com/go-ruby-strscan/strscan v0.0.0-20260630060240-10bd95a9c4a4 h1:SHtLFEJV/qaEhB4CuQxnRyMMVa+89nYwZqO8t2PjNrg=
Expand Down
4 changes: 1 addition & 3 deletions internal/vm/bag.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,7 @@ func (b *Bag) seed(v object.Value) {
b.add(el)
}
case *Set:
for _, k := range e.order {
b.add(e.vals[k])
}
e.each(b.add)
case *Bag:
e.b.Each(func(item interface{}, count int) goresult.Interface {
for i := 0; i < count; i++ {
Expand Down
Loading
Loading