Repository navigation
Raise the ruby/spec floor 22475 -> 23113 after waves 33-36 - #696
Merged
Merged
Conversation
Provisional, and deliberately conservative: 22650 is the number CI's own ratchet read on #685 (Dir.pwd) before #692 (the mspec shim repair) merged, so it is known-good rather than predicted. The two land together for the first time on this branch, and they interact: #685 makes Dir.pwd raise when the working directory has been removed, while #692 restores the `after :all` hook whose absence was what removed it. Neither branch's CI ran with the other. So this PR is also the measurement. Its own ratchet lane reports the real total for the combined tree, and the floor is then set to that figure in a follow-up commit here — taken from the lane that applies it, never from a development host, which reads a different number. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The provisional 22650 was the reading on #685 before #692 merged. The combined tree reads 23113 — the same total #692 measured on its own, so #685's -122 did NOT subtract from it. That is informative rather than a coincidence: the 122 examples #685 removed were the Dir specs continuing past a deleted working directory, and #692 restores the `after :all` hook whose absence deleted it. With the hook back, the directory survives and Dir.pwd never has to raise. The two changes address one root cause from opposite sides and overlap instead of composing, which is why predicting the sum would have been wrong in either direction. Taken from the lane that applies the floor, on the merge of this branch with main, not from a development host. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this locks in
Waves 33–36 merged today: TracePoint-era work aside, the movers were
instance_variable_seton native kinds (#672)do…endas a paren-less argumentString#encodeDir.pwdraises on a removed cwd (#681)arg_valueTwo of those numbers deserve their sign explained
#685 is −122 and that is the point.
Dir.pwddiscardedos.Getwd()'s error,so the
Dirspecs — which delete the working directory in teardown — kept runningwhere MRI's failure cascades. rbgo scored 92 on
core/dir/glob_spec.rbagainstMRI's 16 through our own shim: roughly 145 examples counted as passing with no
reference able to reach them. Removing them made the measurement stricter, not
worse. Same shape as #660, where repairing
ShouldProxycorrectly lowered thefloor by 175.
#683 and #694 each moved zero examples, and are still conformance wins. The
parser now accepts 27 loop-condition shapes MRI accepts, and refuses 40 it
refuses; real Ruby writes none of them, so no corpus can witness either change.
Both were measured by enumerating shapes against MRI's two parsers
(
--parser=prismand--parser=parse.y), which is the only instrument that cansee them.
Why this PR carries a provisional number
22650 is known-good rather than predicted: it is what CI's ratchet read on
#685 before #692 merged. #685 and #692 interact — #685 makes
Dir.pwdraise whenthe working directory has been removed, and #692 restores the
after :allhookwhose absence was what removed it — and neither branch's CI ran with the other
(#692's lanes completed at 16:54Z, #685 merged at 17:55Z).
Rather than guess the combined total, this PR measures it: its own ratchet lane
prints the real figure, and a second commit here sets the floor to exactly that.
The number is taken from the lane that applies it; a development host reads a
different one, and a floor set below what the judge sees is slack rather than
safety.
The judge did not become lenient
#692 is a large change to our own measuring instrument, so the control that
matters is what it did to the reference, not to us:
MRI rose twice as much as rbgo, MRI's unscoreable set fell 531 → 112, no file
moved down for MRI, and nowhere did rbgo rise while MRI did not. The repaired
instrument also makes headroom legible for the first time: 1528 reachable
examples, with 85 files scoring 0 for rbgo where MRI scores above 0.
🤖 Generated with Claude Code