Repository navigation
ci: enforce 100% coverage gate on POSIX lanes only (not windows) - #542
Merged
Merged
Conversation
The windows runner cannot execute a handful of POSIX-only code paths (e.g. opening "/dev/null" as a character device), so its measured merged coverage is structurally below 100% — a FLOOR-only PR and trivial dependency PRs fail `test (windows-latest)` on `coverage 99.9% < 100%` identically. The full suite still runs under -race on windows to catch real, platform-specific failures; only the coverage threshold is not gated there. ubuntu and macOS (both POSIX) continue to enforce the strict 100% gate. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
tannevaled
added a commit
that referenced
this pull request
Aug 31, 2026
tannevaled
added a commit
that referenced
this pull request
Aug 31, 2026
tannevaled
added a commit
that referenced
this pull request
Aug 31, 2026
tannevaled
added a commit
that referenced
this pull request
Aug 31, 2026
tannevaled
added a commit
that referenced
this pull request
Aug 31, 2026
tannevaled
added a commit
that referenced
this pull request
Aug 31, 2026
tannevaled
added a commit
that referenced
this pull request
Aug 31, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The windows runner cannot execute a few POSIX-only code paths (e.g. opening
/dev/nullas a character device), so its measured merged coverage is structurally < 100%. A FLOOR-only PR and trivial dependency PRs failtest (windows-latest)oncoverage 99.9% < 100%identically — it is not signal about a PR's code.This keeps running the full suite under -race on all three OS lanes (so real windows-specific failures are still caught), but enforces the strict 100% coverage threshold on the POSIX lanes (ubuntu, macOS) only. Windows prints its coverage and skips the threshold check.
🤖 Generated with Claude Code