Repository navigation
Bump go-regexp/engine: \xHH regexp hex-byte escape - #521
Merged
Merged
Conversation
go-regexp/engine v0.1.3 parses the \xHH hex-byte escape (one or two hex
digits), both as a standalone atom and inside a character class, so
patterns such as /\x41/ and /[\x00-\x7f]/ compile instead of raising a
RegexpError. Matches Onigmo/Ruby (no brace \x{…} form in a regexp).
go test ./... green, native + wasip1/wasm build.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
tannevaled
added a commit
that referenced
this pull request
Aug 31, 2026
* Raise ruby/spec floor to 17470 after wave-3 conformance work Locks in the gains from #521 (regexp \xHH), #523 (String#encode fallback/xml/IBM437/default_internal), #524 (Marshal Data + Regexp encoding), #525 (Module#define_method arity/visibility/hooks) and #522 (sprintf %c/named-default/hex-float). Measured 17470 passing on the pinned corpus, up from 17310. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * ci: re-trigger after transient GOPROXY stream errors Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-regexp/engine v0.1.3 parses the
\xHHhex-byte escape (one or two hex digits), both as a standalone atom and inside a character class, so patterns such as/\x41/and/[\x00-\x7f]/compile instead of raising aRegexpError. Matches Onigmo/Ruby (no brace\x{…}form in a regexp; a\xwith no hex digit is a syntax error).go test ./...green, native +wasip1/wasmbuild. FLOOR left untouched (bumped in a consolidating change with the parallel conformance PRs).🤖 Generated with Claude Code