Skip to content

fix(profiling-node): 137 ABI should not be pruned for node 24 - #19236

Merged
nicohrubec merged 1 commit into
developfrom
nh/fix-node-24-abi
Feb 9, 2026
Merged

nicohrubec merged 1 commit into
developfrom
nh/fix-node-24-abi

Conversation

@nicohrubec

@nicohrubec nicohrubec commented Feb 9, 2026 •

Copy link
Copy Markdown
Member

For stable node v24 the correct ABI is 137, so this should not be pruned (currently 134 is excluded from pruning for node v24, which only applies for node v24.0.0-pre).

Closes #19234

@nicohrubec
nicohrubec marked this pull request as ready for review February 9, 2026 12:47
@nicohrubec
nicohrubec requested a review from JPeer264 February 9, 2026 12:47
@github-actions

github-actions Bot commented Feb 9, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊


Generated by Codecov Action

@nicohrubec nicohrubec changed the title fix(profiling-node): 137 abi should not be pruned for node 24 fix(profiling-node): 137 ABI should not be pruned for node 24 Feb 9, 2026
@nicohrubec
nicohrubec merged commit a7853bf into develop Feb 9, 2026
41 checks passed
@nicohrubec
nicohrubec deleted the nh/fix-node-24-abi branch February 9, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(profiling-node): sentry-prune-profiler-binaries --target_node=24 incorrectly removes version 137

2 participants