Skip to content

bug(profiling-node): sentry-prune-profiler-binaries --target_node=24 incorrectly removes version 137 #19234

Description

@kallekj

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/aws-serverless

SDK Version

10.38.0

Framework Version

NodeJS 24

Link to Sentry event

No response

Reproduction Example/SDK Setup

Run:

sentry-prune-profiler-binaries --target_dir_path=./dist --target_platform=linux --target_node=24 --target_stdlib=glibc --target_arch=arm

Output:

Sentry: pruned ./dist/sentry_cpu_profiler-darwin-arm64-108-BVXYV7N3.node (113.01 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-darwin-arm64-115-5LPNQSFC.node (113.01 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-darwin-arm64-127-FYSO2UAU.node (113.01 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-darwin-arm64-137-23XFWLCR.node (112.46 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-darwin-x64-108-MKIFJ4WK.node (112.08 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-darwin-x64-115-LTITCSGG.node (112.08 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-darwin-x64-127-VDGWJUTX.node (112.08 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-darwin-x64-137-R745VZAB.node (111.54 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-arm64-glibc-108-CJZB4KLU.node (68.98 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-arm64-glibc-115-CJZB4KLU.node (68.98 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-arm64-glibc-127-6LW7LSQD.node (68.98 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-arm64-glibc-137-EH3YCIAG.node (68.77 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-arm64-musl-108-LX4JYJPH.node (68.81 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-arm64-musl-115-LX4JYJPH.node (68.81 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-arm64-musl-127-LX4JYJPH.node (68.81 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-arm64-musl-137-2JFRG4C2.node (68.61 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-x64-glibc-108-U2E4XH2G.node (75.70 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-x64-glibc-115-U2E4XH2G.node (75.70 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-x64-glibc-127-6B4T4SYX.node (71.70 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-x64-glibc-137-Y532LOC3.node (71.43 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-x64-musl-108-FZQ3PY5A.node (71.03 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-x64-musl-115-FZQ3PY5A.node (71.03 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-x64-musl-127-RBUGFAXA.node (71.02 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-x64-musl-137-JZHDR53W.node (73.70 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-win32-x64-108-Y6IARABQ.node (221.00 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-win32-x64-115-T63UH7RL.node (221.00 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-win32-x64-127-TYQLNOV7.node (221.00 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-win32-x64-137-JIKTOVBH.node (221.00 KiB)
✅ Sentry: pruned 28 binaries, saved 2.85 MiB in total.

Steps to Reproduce

  1. Run command: sentry-prune-profiler-binaries --target_dir_path=./dist --target_platform=linux --target_node=24 --target_stdlib=glibc --target_arch=arm
  2. Observe that it incorrectly removes the -137-.node binary.

Expected Result

That the -137-.node version is not pruned.

Actual Result

Sentry: pruned ./dist/sentry_cpu_profiler-darwin-arm64-108-BVXYV7N3.node (113.01 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-darwin-arm64-115-5LPNQSFC.node (113.01 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-darwin-arm64-127-FYSO2UAU.node (113.01 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-darwin-arm64-137-23XFWLCR.node (112.46 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-darwin-x64-108-MKIFJ4WK.node (112.08 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-darwin-x64-115-LTITCSGG.node (112.08 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-darwin-x64-127-VDGWJUTX.node (112.08 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-darwin-x64-137-R745VZAB.node (111.54 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-arm64-glibc-108-CJZB4KLU.node (68.98 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-arm64-glibc-115-CJZB4KLU.node (68.98 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-arm64-glibc-127-6LW7LSQD.node (68.98 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-arm64-glibc-137-EH3YCIAG.node (68.77 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-arm64-musl-108-LX4JYJPH.node (68.81 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-arm64-musl-115-LX4JYJPH.node (68.81 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-arm64-musl-127-LX4JYJPH.node (68.81 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-arm64-musl-137-2JFRG4C2.node (68.61 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-x64-glibc-108-U2E4XH2G.node (75.70 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-x64-glibc-115-U2E4XH2G.node (75.70 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-x64-glibc-127-6B4T4SYX.node (71.70 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-x64-glibc-137-Y532LOC3.node (71.43 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-x64-musl-108-FZQ3PY5A.node (71.03 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-x64-musl-115-FZQ3PY5A.node (71.03 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-x64-musl-127-RBUGFAXA.node (71.02 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-linux-x64-musl-137-JZHDR53W.node (73.70 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-win32-x64-108-Y6IARABQ.node (221.00 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-win32-x64-115-T63UH7RL.node (221.00 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-win32-x64-127-TYQLNOV7.node (221.00 KiB)
Sentry: pruned ./dist/sentry_cpu_profiler-win32-x64-137-JIKTOVBH.node (221.00 KiB)
✅ Sentry: pruned 28 binaries, saved 2.85 MiB in total.

Error in Lambda running node24:
Image

Additional Context

The Sentry bot in PR #18447 mentioned this as bug #18447 (comment)

Priority

React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions