Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
…filtering Add a page for piDurableIntegration (SDK 11.6.0), list it in the agent tracing grid and the runtime integration tables, and document which internal Durable Object SQL tables get no spans and the durableObjectSqlSpanAllowlist option. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
b3daa11 to
1df43df
Compare
|
The change publishes a new integration page and updates nearby JavaScript docs. The plan checks that the new page is reachable. An issue escalates when JavaScript docs return server errors or missing-file logs appear. Services: Mention PlanWhat changedReaders of JavaScript docs can now open a pi-durable integration page. Cloudflare Durable Object docs now describe SQL span filtering and durableObjectSqlSpanAllowlist. The sentry-docs service must deploy before this change is live. Deploy config maps the Vercel production project sentry-docs to this catalog id. The change lives under product docs. It does not ship in develop-docs. RiskBroken MDX can 404 the new page after deploy. The same break can take down JavaScript integration index pages that include the new table row. Cloudflare Durable Object and agent-tracing pages can fail to render. Readers then lose setup steps or hit missing pages. Intended effectThe new pi-durable docs pages start to receive HTTP requests. Absent looks like those URLs stay at zero while sibling integration pages still receive traffic. Traces sample at 30 percent. A quiet page may stay at zero in sampled spans.
Regression watchThis change can break JavaScript docs pages that include the new MDX. Watch server failures and missing-file logs on that path. Also watch error events on JavaScript docs pages.
If the 5xx share or the missing-file logs rise, inspect JavaScript integration pages and the Cloudflare Durable Object page first. Not observableWhether the new prose and code samples are correct. Search index coverage for the new page. Whether each JavaScript guide variant of the common page renders. CDN hit counts. Unsampled page views. Path-level 404s. The docs.page.not_found metric only stores the first two path segments. Get Slack DMs about this change: cursor.com/automations/rollouts |
|
|
||
| </SdkOption> | ||
|
|
||
| <SdkOption name="durableObjectSqlSpanAllowlist" type='Array<string | RegExp>' defaultValue='[]' availableSince='10.67.0'> |
There was a problem hiding this comment.
Bug: durableObjectSqlSpanAllowlist is documented with availableSince='10.67.0', but it likely became available in SDK version 11.6.0 alongside pi_ prefix filtering.
Severity: LOW
Suggested Fix
Verify the SDK release version for durableObjectSqlSpanAllowlist and update availableSince to '11.6.0' if the option was introduced in that version.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: docs/platforms/javascript/common/configuration/options.mdx#L579
Potential issue: The `durableObjectSqlSpanAllowlist` option documentation specifies
`availableSince='10.67.0'`, but its description covers both `cf_` and `pi_` prefix
filtering. The `pi_` prefix filtering and associated integration were introduced in SDK
version 11.6.0. Users running versions between 10.67.0 and 11.5.x who attempt to
configure this option according to the docs will find it non-functional.
Did we get this right? 👍 / 👎 to inform future reviews.
|
closing in favor of #19873 |
DESCRIBE YOUR PR
This adds a page for
piDurableIntegration(getsentry/sentry-javascript#24993, SDK 11.6.0), which is on by default, and lists it in the agent tracing grid and the runtime integration tables. It also documents which internal Durable Object SQL tables create no spans (cf_, andpi_since getsentry/sentry-javascript#25028) and thedurableObjectSqlSpanAllowlistoption that brings them back.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace
YYYY-MM-DDwith the due date. You can update this information later by editing the PR description.SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES