Conversation
JPeer264
added this pull request to stack #25002
October 2, 2026 13:14
Contributor
size-limit report 📦
|
JPeer264
removed this pull request from stack #25002
October 2, 2026 13:31
JPeer264
changed the base branch from
jp/flue-map-messages-conventions
to
jp/bun-conversation-id-integration
October 2, 2026 13:39
JPeer264
force-pushed
the
jp/pi-durable-instrumentation
branch
from
October 2, 2026 13:39
1dad424 to
91a0b35
Compare
JPeer264
added this pull request to stack #25004
October 2, 2026 13:57
JPeer264
force-pushed
the
jp/pi-durable-instrumentation
branch
from
October 2, 2026 16:59
91a0b35 to
26d39c9
Compare
JPeer264
force-pushed
the
jp/pi-durable-instrumentation
branch
from
October 3, 2026 16:23
26d39c9 to
4fc5960
Compare
JPeer264
removed this pull request from stack #25004
October 5, 2026 07:21
JPeer264
added this pull request to stack #25029
October 5, 2026 07:22
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4fc5960. Configure here.
| const run = | ||
| isRunWork || kind === PI_TASK.COMPACTION | ||
| ? (runs.active.get(conversationId) ?? (isRunWork ? startRun(conversationId, runs) : undefined)) | ||
| : undefined; |
There was a problem hiding this comment.
Abort can start leaked agent runs
Medium Severity
abort is wrapped with the same runPhase path as live generation and tool work, and that path starts a new invoke_agent run whenever the conversation has no active run. subscribeClose already ends those runs when close() begins, after which built-in abort handlers still run. A late abort then opens a fresh run that close will not see, so the span can leak until the tracker overflows.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 4fc5960. Configure here.
| langChainIntegration(), | ||
| langGraphIntegration(), | ||
| mastraIntegration(), | ||
| piDurableIntegration(), |
There was a problem hiding this comment.
Default enablement lacks changelog notes
Low Severity
piDurableIntegration is added to default tracing integrations, and the first model request disables the OpenAI, Anthropic, Google GenAI, and Workers AI integrations process-wide. That is a silent default change for apps that already use pi-durable alongside those SDKs, and Unreleased has no changelog or migration note. Flagged because the review rules call out silent default changes without migration notes.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 4fc5960. Configure here.
pi-durable has no telemetry hooks, so `piDurableIntegration` wraps the `models` and `registry` passed to `Harness.open()`. Each run becomes its own `invoke_agent` trace with `chat` and `execute_tool` children, and a subagent run nests under the tool call that started it. Messages are mapped to the gen_ai conventions, and the system prompt and tools are read from pi-durable's positional system messages. Tool spans record the result the model receives. Failures pi-durable only reports, and task phases that throw, are captured. Throws of the built-in coding tools are not, because they report expected results to the model. On Cloudflare it also covers pi-durable in a Durable Object through the Agents SDK `PiHarness`, including requests that pi-ai sends through the Workers AI binding. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/pi-durable-instrumentation
branch
from
October 5, 2026 09:44
4fc5960 to
f8eb62c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
piDurableIntegrationfor@earendil-works/pi-durable, Earendil's new durable agent harness. It is on by default in Node, Bun and Deno, and in a Worker built with@sentry/cloudflare/vite, which covers pi-durable in a Durable Object through the Agents SDKPiHarness. Each run becomes its owninvoke_agenttrace withchatandexecute_toolchildren, and the first run of a subagent conversation nests under the tool call that created it.pi-durable has no telemetry hooks (
pi-telemetryexists, but no pi package emits spans through it yet), so the integration hooksHarness.open()and wraps themodelsandregistryit receives. The wrapped options keep the caller's options as prototype, because pi-durable readssettings,envandconversationCreatedat every use.Decisions worth a look:
pi.generationtask after every tool round, so no single task spans a run. The run span ends when the commit that removespi.live.rungoes through, or when the Harness closes with the run in flight.@sentry/cloudflarebinds the client to the scope of each request, not to the default scope.gen_ai.conversation.idis<harness id>:<conversation id>. pi-durable numbers conversations per storage from 1, so the bare id would merge every root conversation into one. The cost is a new id after a restart (on Cloudflare, after every restart of the Durable Object), until pi-durable has a stable storage id.api.output()(all ofbash) and results anafterToolhook redacted.onReport(throwing hooks or sections) and task phases that throw are captured. Throws of the built-in coding tools are not, becausebashthrows for every non-zero exit, a normal result for a coding agent. The built-in tools are recognized by their factories (createBashTool()and friends), so an app that registers them in an extension of its own gets the same treatment. The span keeps its error status.openai,@anthropic-ai/sdkand@google/genaiclients, or through the Workers AI binding withcreateAI()ofagents/models/pi-ai, and those integrations cannot tell pi-ai's calls from the app's own. Bedrock requests go through the AWS SDK, whichawsIntegrationstill reports twice; that skip is a follow-up.Messages, token usage and finish reasons go through the pi-ai mapper from the Flue fix, and the system prompt and tools are replayed from pi-durable's positional system messages.
Not covered yet: spans for tool calls pi-durable answers without running
execute(), spans for custom tasks, agent names (pi-durable has none), a link between a run and the request that submitted it, a marker for compaction requests, and an error event for a failed model request (thechatspan carries the status).🤖 Generated with Claude Code