Skip to content

fix(project): contain managed paths within project root - #182

Merged
gricha merged 1 commit into
mainfrom
fix/project-scope-containment
Sep 9, 2026
Merged

gricha merged 1 commit into
mainfrom
fix/project-scope-containment

Conversation

@gricha

@gricha gricha commented Sep 9, 2026

Copy link
Copy Markdown
Member

Project-scoped commands now reject managed and generated paths that lexically escape the project or resolve outside it through an existing symlink. This covers canonical .agents state, legacy skill targets, MCP, hook and subagent output, plugin runtime projections, and managed gitignore files; symlink aliases that stay inside the project continue to work.

Previously a repository could commit an outward-pointing .agents, .codex, or similar harness directory, or use traversal in [symlinks].targets, causing --project install to persist repository-controlled agent configuration outside the checkout. Install did not execute that configuration, but a later harness session could load the MCP, hook, subagent, or plugin configuration.

The containment check resolves the nearest existing ancestor so not-yet-created output paths remain valid. User-scope paths and Git worktree common-directory hooks are intentionally unchanged.

@vercel

vercel Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
dotagents Ready Ready Preview Sep 9, 2026 6:41am UTC

Request Review

@github-actions github-actions Bot added the risk: medium PR risk score: medium label Sep 9, 2026
@gricha
gricha merged commit de189d6 into main Sep 9, 2026
19 checks passed
@gricha
gricha deleted the fix/project-scope-containment branch September 9, 2026 07:13
mishamilovidov added a commit to mishamilovidov/dotagents that referenced this pull request Sep 9, 2026
Reconcile the marketplace-name migration with Copilot plugin support (getsentry#166) and project-path containment (getsentry#182). The Copilot marketplace generation call site is corrected to match the two-argument pathMarketplace signature after the merge.

This branch was successfully deployed

1 active deployment
Preview — d985d657 Deployed Sep 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant