Allow truffle to fail silently on package fetch error - #216
Merged
Merged
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3928ad9. Configure here.
A setup failure now leaves a green check, so without an annotation there is no sign on the PR that the change went unscanned. Report which stage broke. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
always() is true even when cancelled, so ANDing it with !cancelled() reduces to !cancelled(), which is the form GitHub recommends. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
geoffg-sentry
approved these changes
Sep 11, 2026
geoffg-sentry
left a comment
geoffg-sentry
left a comment
Contributor
There was a problem hiding this comment.
Closed my #215 in favour of this. It drops a couple of things I was doing for additional redundancy, but I think I prefer the simpler design for troubleshooting purposes.
Jeffreyhung
deleted the
allow-truffle-to-fail-on-package-fetch-error
branch
September 11, 2026 17:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--retry 3 --retry-delay 5to minimize the time, 2 min waiting period is too long--github-actionsfor truffle scan so that the secrets will be flagged in PR directlyReasoning:
The chance of truffle package setup failure is low and we rather maintain usability than enforce secret scan, hence if it ever ran into error, we allow it to fail silently without blocking the PR