Softer failures for secret scan download problems - #215
Closed
geoffg-sentry wants to merge 1 commit into
Closed
geoffg-sentry wants to merge 1 commit into
geoffg-sentry wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trufflehog download failures from GH availability issues shouldn't hard block PRs. Updating the workflow so it can manage a soft failure of trufflehog being unavailable by allowing the org-wide check to pass green and distinguishing the failure types in the messages delivered to SIEM. Given higher occurrence rates of GH availability issues causing scan failures versus the true positive scan results in PRs this is entirely reasonably.
Future: self-host trufflehog (and maybe cosign) behind a CDN we run to reduce the failure states all together. Hard to trust github for availability given how often these secret scans run SEC-1890