build(t27c): put the web stack behind cargo features (212 -> 49 crates) - #5914
Merged
Merged
Conversation
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This was referenced Oct 4, 2026
gHashTag
force-pushed
the
claude/rust-cpp-compiler-perf-169df3
branch
from
October 4, 2026 07:32
765ff41 to
ff87c22
Compare
The default build of t27c compiled reqwest, TLS, tokio, axum, hyper and jsonwebtoken although only serve, bench-endpoints, bridge and audio use them. Default now resolves 49 crates instead of 212. - net = reqwest, for bridge and audio; server implies net - uuid, tower and ignore were not imported anywhere: removed - bridge's HTTP half moves to bridge/client.rs; without net, bridge (except handoff) and audio exit 1 naming --features net - jwt/proxy unit tests keep running under plain cargo test through dev-dependencies (#2301) cargo test -p t27c: 2789 passed, 2 failed, identical to the base commit. Closes #5912 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gHashTag
force-pushed
the
claude/t27c-net-feature
branch
from
October 4, 2026 07:33
1aa4cb0 to
8af8795
Compare
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This was referenced Oct 4, 2026
Merged
gHashTag
changed the base branch from
claude/rust-cpp-compiler-perf-169df3
to
master
October 4, 2026 08:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5912. Part of #5905 (weak point 5, t27c build time). Stacked on #5900; retarget to
masterafter #5900 merges.What changes
cargo build -p t27cstops building an HTTP client, TLS, an async runtime, a web framework and a JWT library. Onlyserve,bench-endpoints,bridgeandaudiouse them.netreqwestbridge,audioservernet+ axum, tokio, hyper, hyper-util, http-body-util, tower-http, tokio-stream, futures-util, jsonwebtoken, serde_urlencodedserve,bench-endpointsuuid,towerandignorewere not imported by any file and are removed.bridge.rsmoves tobridge/client.rsundercfg(feature = "net").bridge handoffreads a local file, so it stays in every build.net, the otherbridgesubcommands andaudioexit 1 and print the rebuild command (--features net). They do not vanish from--help.jsonwebtoken,hyperandserde_urlencodedare also dev-dependencies, so thejwt::testsandproxy::testsunit tests still run under a plaincargo test(proxy.rs tests are stripped before type-checking — no workflow passes --features server #2301).Dockerfilealready builds--features serverand is unchanged.Measured
cargo tree -p t27c -e normal,build --prefix none | sort -u | wc -l:--features net--features servercargo check --release -p t27cpasses for each of the three configurations.cargo test -p t27c --no-fail-fast, default features: 2789 passed, 2 failed, the same result as the base commite82a5b4e4. Both failures are already red there and do not involve these crates:each_backend_artefact_write_is_guarded_at_its_own_call_site(tests/corpus_unresolved.rs:309)corpus_classifier_matches_lean_completeness(icarus_lowerable)The six
jwt::tests/proxy::teststests run and pass.Behaviour without
net:🤖 Generated with Claude Code