Skip to content

fix(queen): a required check that refuses the pull request takes the acceptance back - #507

Merged
gHashTag merged 1 commit into
feat/queen-supervisorfrom
fix/ci-refusal-takes-back-accept
Sep 22, 2026
Merged

gHashTag merged 1 commit into
feat/queen-supervisorfrom
fix/ci-refusal-takes-back-accept

Conversation

@gHashTag

Copy link
Copy Markdown
Owner

Why the reviews jam

On gHashTag/t27 on 2026-09-22, the review accepted #4385 and publish opened #4578 for it. The required parse-ratchet check refused it: parse error in fn 'is_coq' near line 17. The PR sat red for ever. The issue stayed open with an accept on it, and the Queen skipped it every round as "the work already landed". 42 issues were in that state while the swarm ran 2 bees of 20, and no bee ever saw the error.

What changes

queen-ci-verdict.ts, called each round right after the review. For up to 8 accepted issues (oldest-asked first, tracked in the new ci_checked_at column):

  • It finds the open PR for queen-N and reads the required checks from the base branch's rules.
  • If a required check completed red on the PR head, the accept becomes a sendBack. Its note is the check's own ##[error] line, which the next bee reads in its brief (judged_note). The second refusal escalates to a person, the review's own ceiling.
  • It decides nothing on a running or advisory check, takes nothing back when the required list cannot be read, and leaves closed or merged PRs alone. It runs as housekeeping, so a failure is logged and the round still starts bees.

Verified

  • Against live t27: the required checks read as validate, check-linked-issue, parse-ratchet. queen-4385 resolves to #4578 (open) with parse-ratchet red, and the error line is extracted. The merged #4579 and a missing branch are left alone.
  • New tests (14) include the real #4578 log.
  • All Queen suites: 628 pass, 0 fail (614 before).

🤖 Generated with Claude Code

…acceptance back

Measured 2026-09-22 on gHashTag/t27: the review accepted #4385, publish
opened #4578, and the required parse-ratchet refused it ("parse error in
fn 'is_coq' near line 17"). The pull request sat red for ever, the issue
stayed open with an accept on it, and the Queen skipped it every round as
"the work already landed". 42 issues were in that state while the swarm
ran 2 bees of 20, and no bee ever saw the error.

Each round now asks GitHub about up to eight accepted issues, oldest-asked
first: is there an open pull request for the branch, and did a REQUIRED
check (read from the base branch's rules) come back red on its head? If so
the accept becomes a sendBack whose note is the check's own ##[error] line,
which the next bee reads in its brief (judged_note). The second refusal
escalates, the review's own ceiling.

It decides nothing on a running or advisory check, takes nothing back when
the required list cannot be read, leaves closed and merged pull requests
alone, and runs as housekeeping: a failure is logged and the round goes on
to start bees.

Verified against live gHashTag/t27: required checks read as validate,
check-linked-issue, parse-ratchet; queen-4385 -> #4578 open, parse-ratchet
red, error line extracted; a merged pull request and a missing branch are
left alone. Queen suites: 628 pass (614 before + 14 new), 0 fail.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions github-actions Bot added the fix label Sep 22, 2026
@github-actions

Copy link
Copy Markdown

❌ Tests failed — 1/2453 failed

Suite Passed Failed Skipped
✅ agent 87/87 0 0
✅ build 9/9 0 0
✅ cdp-protocol 5/5 0 0
✅ eval 93/93 0 0
✅ server-agent 272/272 0 0
✅ server-api 1272/1331 0 59
✅ server-browser 6/6 0 0
✅ server-integration 10/11 0 1
✅ server-lib 279/279 0 0
✅ server-pglive 3/3 0 0
✅ server-root 68/68 0 0
✅ server-skills 31/31 0 0
❌ server-tools 243/244 1 0
✅ shared 14/14 0 0
Failed tests
  • server-tools — search_dom > finds elements by CSS selector

View workflow run

@gHashTag
gHashTag merged commit a251e9d into feat/queen-supervisor Sep 22, 2026
31 of 33 checks passed
@github-actions
github-actions Bot deleted the fix/ci-refusal-takes-back-accept branch September 27, 2026 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant