Repository navigation
Feature/junit5 preparations - #145
Merged
mjg123 merged 11 commits intoJul 30, 2018
Merged
Conversation
merge from origin
PR from origin
- separation of the junit4 and junit5 code into different modules. - core module to share code between different TDD frameworks
This was referenced Jul 23, 2018
Closed
Contributor
Author
|
for integration test-7 : fnproject/cli#349 With this we can use junit4 as default until we are switching to jUnit5 as default. |
|
Compilation failure in the integration tests - I'll have a look. |
Contributor
Author
|
it should be integration test 7, that is using cli |
# Conflicts: # examples/async-thumbnails/src/test/java/com/fnproject/fn/examples/ThumbnailsFunctionTest.java # fn-spring-cloud-function/src/test/java/com/fnproject/springframework/function/testfns/EmptyFunctionConfig.java
Contributor
Author
|
deactivated integration test 3 and 7 to break the cycle between cli and fdk |
mjg123
approved these changes
Jul 30, 2018
mjg123
left a comment
mjg123
left a comment
There was a problem hiding this comment.
Spoke f2f with Sven about this and we agree on the general approach. ITs need disabling to break a cyclical dependency between CLI and FDK_JAVA.
mjg123
approved these changes
Jul 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracted the junit4 code into separate module
all dependencies are using this right now inside this project
module testing is empty so far, but will contain junit5 code later
this merge request is based on the need to hold the old module name testing
testing-junit4 will be used for the orig testing code base
teting-core will be used for the generic code that could be used for junit4 and junit5
testing will be the "home" for the new junit5 code base