Skip to content

Feature/junit5 - #144

Closed
mjg123 wants to merge 3 commits into
masterfrom
feature/junit5
Closed

mjg123 wants to merge 3 commits into
masterfrom
feature/junit5

Conversation

@mjg123

@mjg123 mjg123 commented Jul 2, 2018

Copy link
Copy Markdown

Rebase of this #141
onto this #143

Matthew Gilliard and others added 2 commits July 2, 2018 10:36
Using snyk.io tools we found several dependencies had security vulnerabilities
and could be updated. This does not remove all of them, but the remaining CVEs
are in transitive dependencies brought in by 3rd party code.

CVEs remain in:

async-thumbnails example (low priority to fix) through
  - minio
  - wiremock

fn-spring-cloud-function through
  - spring-cloud-function-context

Additional changes were needed to adjust for API changes in updated dependencies:

async-thumbnails example:
  - new minio client uses chunked file uploads so assertions needed changing

fn-spring-cloud-function:
  - Several breaking API changes, and it seems now that Consumer behaviour is broken.
- separation of the junit4 and junit5 code into different modules.
- core module to share code between different TDD frameworks
@mjg123

mjg123 commented Jul 2, 2018

Copy link
Copy Markdown
Author

CI fails, but it passed locally :(

@mjg123
mjg123 force-pushed the feature/junit5 branch 2 times, most recently from 626d8e7 to 1ea30f1 Compare July 2, 2018 10:39
@mjg123

mjg123 commented Jul 2, 2018

Copy link
Copy Markdown
Author

All passing except for timeouts in the integration tests.

@svenruppert

Copy link
Copy Markdown
Contributor

created preparations at #145

@mjg123

mjg123 commented Jul 24, 2018

Copy link
Copy Markdown
Author

Closing in favour of #145

@mjg123 mjg123 closed this Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants