Repository navigation
Throw CborContentException for dangling tag at end of root-level sequence - #135359
Merged
bartonjs merged 4 commits intoOct 12, 2026
Merged
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-formats-cbor, @bartonjs, @vcsjones |
This was referenced Oct 7, 2026
Closed
bartonjs
reviewed
Oct 7, 2026
bartonjs
approved these changes
Oct 8, 2026
eiriktsarpalis
approved these changes
Oct 12, 2026
Contributor
Author
|
CI failed only on JSImportGenerator.Unit.Tests (windows-x86 CoreCLR_AllSubsets), exit code 0xC0000005 crash in an unrelated project. All System.Formats.Cbor tests passed. Could someone rerun the failed job? Thanks! |
eiriktsarpalis
added a commit
that referenced
this pull request
Oct 14, 2026
…135621) <!-- --> Reserved additional-information values 28-30 are malformed CBOR, but `ReadSimpleValue` reports their initial bytes (`0xFC`, `0xFD`, `0xFE`) as `InvalidOperationException`. The same exception escapes through the skip and encoded-value APIs. These inputs now throw `CborContentException`, including when conformance checks are disabled. The check is confined to the existing error branch. Valid floating-point encodings and container-end misuse retain `InvalidOperationException`. Regression coverage includes nested values, incremental input, all conformance modes, and reader rollback. This is independent of the dangling-tag fix in [#135359](#135359), with no changed-file overlap. `ReadUnixTimeSeconds` now translates both `ArgumentOutOfRangeException` and `OverflowException` from numerical conversion to `InvalidOperationException` when the encoded Unix time cannot be represented by `DateTimeOffset`. The original exception is preserved as the inner cause, and failures restore the reader checkpoint. The numerical operations are unchanged, with no success-path preflight checks. Tests cover numeric boundaries and recovery, including strict map-key validation. `ReadDecimal` retains its existing `OverflowException` behavior; well-formed out-of-range values are not reclassified as malformed CBOR. > [!NOTE] > This pull request was prepared with GitHub Copilot. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0d9a0557-8d2c-459a-9c86-4f143c98b2a4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #135191
CborReadernow throwsCborContentExceptionwhen a root-level value sequence (AllowMultipleRootLevelValues) ends with a tag that is not followed by a data item, instead of reportingFinished. This applies to both single-buffer and incremental (SlideData) readers, so equivalent states now throw the same exception type.Changes:
PeekStateCore: throw at the end of a root-level sequence if a tag is pendingPeekInitialByte: same check before the end-of-sequence guard, which covers the case where the tag is the only token consumed (SlideDatarebases the offset to zero)PeekState_DanglingTagAtEndOfRootSequence, which asserted the oldFinishedbehavior, and added a test for the tag-only caseNote: this changes shipped behavior.
PeekState()previously returnedFinishedfor a dangling root-level tag.Testing: I verified the scenarios from the issue (before and after the change) with a scratch console project that compiles the library sources. I couldn't run the full
System.Formats.Cbortest suite locally, so I'm relying on CI for that.