Repository navigation
[release/11.0] [mono][aot] Fix recursive struct wrapper normalization - #135334
github-actions[bot] wants to merge 3 commits into
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Tagging subscribers to this area: @dotnet/area-system-numerics |
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
|
The tests introduced by this PR are failing - #135348 . The fix for these failures should be included in this PR. |
Remove the mutually recursive generic value types added by the original test. CoreCLR rejects that metadata while loading System.Runtime.Tests, before test discovery, which caused #135348 across unrelated CI legs. Keep the valid self-recursive shape that reproduces the Mono AOT compiler stack overflow and make its helper types private. This matches the corrected test in #135438. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Hi, the code complete date for GA is Monday 19th October. Make sure to merge this PR on that date at the latest, or it won't make it into that release. As a reminder, if this is a product change, you also need Tactics approval before merging this PR (test-only or infra-only changes don't require Tactics approval). Happy to help with the merge if needed! |
Done |
Backport of #135438 to release/11.0.
/cc @pavelsavara
Customer Impact
Blazor WebAssembly AOT publishing deterministically crashes
mono-aot-crosswith a native stack overflow when a value type contains ageneric value-type field instantiated over the containing type. The customer
reproduction is tracked by #132071 and reproduces on .NET 10 and .NET 11.
Regression
This is an existing Mono AOT compiler limitation rather than a regression.
Testing
The corrected backport removes the invalid mutually recursive generic test
types from #135029 that caused #135348. It retains only the valid
self-recursive shape and makes the helper types private.
.\build.cmd -bl -os browser -subset mono+libs -c Release /p:RuntimeFlavor=MonoSystem.Tests.ValueTypeTestsrelease/11.0
mono-aot-crossaot-instances.dllcompiled successfully (14,712/14,747 methods).0xC00000FD.Risk
Low. The native change is limited to recursive gsharedvt wrapper-signature
normalization. It uses the existing non-shared fallback when a value type is
encountered again or the bounded recursion depth is reached. Acyclic value
types retain their prior normalization behavior. The corrected test avoids the
invalid cross-runtime metadata that caused the original CI regression.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.release/X.0(no-stagingsuffix).Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.
Note
This PR description was updated with GitHub Copilot.