Skip to content

Added DateTimeOffset.DayOfWeek - #3092

Merged
rpetrusha merged 1 commit into
dotnet:masterfrom
rpetrusha:dayofweek
Aug 27, 2019
Merged

rpetrusha merged 1 commit into
dotnet:masterfrom
rpetrusha:dayofweek

Conversation

@rpetrusha

Copy link
Copy Markdown

Added DateTimeOffset.DayOfWeek

@rpetrusha rpetrusha added this to the August 2019 milestone Aug 27, 2019
@rpetrusha rpetrusha self-assigned this Aug 27, 2019

@mairaw mairaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rpetrusha
rpetrusha merged commit 86b27cc into dotnet:master Aug 27, 2019
@rpetrusha
rpetrusha deleted the dayofweek branch August 27, 2019 21:30
rpetrusha pushed a commit that referenced this pull request Aug 28, 2019
* fix reference enum field - Part 3 (#3072)

* fix reference enum field

* minor fix

* Apply suggestions from docs review

Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>

* Automatically port Range.OffsetAndLength triple slash (#3079)

* Automatically port Range.OffsetAndLength triple slash

* Update Range.xml

* Remove en-us from links (#3088)

* Update PrimitiveTypeCode summaries (#3091)

* Update NTAccount.xml (#3076)

* Update NTAccount.xml

- Fixed the wrong uppercase. Just run the following powershell `Foreach($group in [System.Security.Principal.WindowsIdentity]::GetCurrent().Groups){ $group.Translate([System.Security.Principal.NTAccount]) }` and you'll see for example `BUILTIN\Users` which is NOT uppercase.
- Added the information about the pre-Windows 2000 name is active directory scenarios.
- Added a hint on how to resolve the real name is active directory scenarios.
- Added hits for localization and well-known/built-in accounts

* Update xml/System.Security.Principal/NTAccount.xml

Co-Authored-By: Bill Wagner <wiwagn@microsoft.com>

* Add references to the DateTime(Offset) support document to relevant JSON APIs (#3078)

* Add references to the DateTime(Offset) support document to relevant JSON APIs

* Address review comments

* Added DateTimeOffset.DayOfWeek (#3092)

* fix reference enum field - Part 4 (#3087)

* fix reference enum field

* Apply suggestions from doc review

Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants