Skip to content

fix reference enum field - Part 4 - #3087

Merged
mairaw merged 2 commits into
dotnet:masterfrom
mairaw:enum-fields-4
Aug 28, 2019
Merged

mairaw merged 2 commits into
dotnet:masterfrom
mairaw:enum-fields-4

Conversation

@mairaw

@mairaw mairaw commented Aug 27, 2019

Copy link
Copy Markdown
Contributor

Went through the files 91-120 of PR #1641, reviewed them and brought just the files and changes needed.

@mairaw mairaw added the migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN label Aug 27, 2019
@mairaw mairaw added this to the August 2019 milestone Aug 27, 2019
@mairaw
mairaw requested a review from scottaddie as a code owner August 27, 2019 04:43
@mairaw mairaw self-assigned this Aug 27, 2019

@rpetrusha rpetrusha left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've left a number of suggestions and one comment for you to consider, @mairaw.

Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
@mairaw
mairaw merged commit 41ed8a3 into dotnet:master Aug 28, 2019
@mairaw
mairaw deleted the enum-fields-4 branch August 28, 2019 02:24
rpetrusha pushed a commit that referenced this pull request Aug 28, 2019
* fix reference enum field - Part 3 (#3072)

* fix reference enum field

* minor fix

* Apply suggestions from docs review

Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>

* Automatically port Range.OffsetAndLength triple slash (#3079)

* Automatically port Range.OffsetAndLength triple slash

* Update Range.xml

* Remove en-us from links (#3088)

* Update PrimitiveTypeCode summaries (#3091)

* Update NTAccount.xml (#3076)

* Update NTAccount.xml

- Fixed the wrong uppercase. Just run the following powershell `Foreach($group in [System.Security.Principal.WindowsIdentity]::GetCurrent().Groups){ $group.Translate([System.Security.Principal.NTAccount]) }` and you'll see for example `BUILTIN\Users` which is NOT uppercase.
- Added the information about the pre-Windows 2000 name is active directory scenarios.
- Added a hint on how to resolve the real name is active directory scenarios.
- Added hits for localization and well-known/built-in accounts

* Update xml/System.Security.Principal/NTAccount.xml

Co-Authored-By: Bill Wagner <wiwagn@microsoft.com>

* Add references to the DateTime(Offset) support document to relevant JSON APIs (#3078)

* Add references to the DateTime(Offset) support document to relevant JSON APIs

* Address review comments

* Added DateTimeOffset.DayOfWeek (#3092)

* fix reference enum field - Part 4 (#3087)

* fix reference enum field

* Apply suggestions from doc review

Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

migration-fixes Indicates PRs that are related to problems caused by the migration from MSDN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants