gha attestations ex - #18707
Merged
Merged
gha attestations ex#18707
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mikeparker
reviewed
Nov 17, 2023
mikeparker
reviewed
Nov 17, 2023
Member
|
@dvdksn Might not be directly related but came across this one: docker/buildx#1988 (comment) |
Contributor
Author
ya I have added a note about this in the attestations page (to @mikeparker's dismay 😈) and there's a note about it below the yaml example here as well |
dvdksn
force-pushed
the
gha-attestations-ex
branch
from
November 17, 2023 16:42
63c7e24 to
95d3e7d
Compare
Contributor
Author
|
ok @crazy-max @mikeparker I've reworked the page a bit. WDYT? |
dvdksn
force-pushed
the
gha-attestations-ex
branch
2 times, most recently
from
November 17, 2023 16:44
2bd2e46 to
da4aa7c
Compare
stephaurelio
left a comment
stephaurelio
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Left a few small style guide comments!
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
gha-attestations-ex
branch
from
November 20, 2023 16:45
da4aa7c to
83f12c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://deploy-preview-18707--docsdocker.netlify.app/build/ci/github-actions/attestations/