build: error on attests on non-multiplatform driver - #1988
Merged
Merged
Conversation
On drivers that do not support multi-platform builds (the default `docker` driver), we do not support building attestations (unless using the containerd store). We need to check this feature before attempting to build using attestations. Also adds a test to ensure that attestations can be pushed to registries at all, and that it adequately fails on the docker driver. Signed-off-by: Justin Chadwell <me@jedevc.com>
jedevc
force-pushed
the
fix-attests-on-docker-driver
branch
from
August 4, 2023 14:29
9e17179 to
e206c58
Compare
jedevc
marked this pull request as ready for review
August 4, 2023 14:29
crazy-max
approved these changes
Aug 4, 2023
Collaborator
Author
|
Hm, I added |
Member
Yes I think it still needs to be backported |
Contributor
|
I think we could add a note in attestation docs too. |
This was referenced Sep 22, 2023
19 of 35 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On drivers that do not support multi-platform builds (the default
dockerdriver), we do not support building attestations (unless using the containerd store).We need to check this feature before attempting to build using attestations.
(thanks @cdupuis for the find 🎉)