Repository navigation
Update code example for pre-existing network - #14851
Merged
Merged
Conversation
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
dockertopia
reviewed
May 30, 2022
Contributor
Author
|
@dockertopia Thank you for your review. I don't see any reasoning why #13958 was made. It appears to be incorrect for me. My suggested change was previously applied here: #6124 Please see the related comment: docker-archive/compose-cli#1856 (comment) |
Member
|
Hmm.. yes, #13958 looks a bit odd indeed; I think the |
glours
approved these changes
May 30, 2022
Contributor
|
@grappler Thanks for catching this one |
dockertopia
approved these changes
May 30, 2022
Contributor
There was a problem hiding this comment.
Thanks @grappler. That was a good catch. Felt compelled to double check based on previous change to the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update the code example to match the new syntax.
Related issues (optional)
Fixes #14683