fix/sdk source install - #4043
Closed
TomCC7 wants to merge 6 commits into
Closed
Conversation
TomCC7
added this pull request to stack #4048
September 10, 2026 05:42
This was referenced Sep 10, 2026
Closed
Closed
❌ 7 Tests Failed:
View the top 3 failed test(s) by shortest run time
View the full list of 7 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
TomCC7
commented
Sep 10, 2026
|
|
||
|
|
||
| def ensure_web_dist(root: Path) -> None: | ||
| """Build the web assets for Git installs and source distributions.""" |
Member
Author
There was a problem hiding this comment.
why we need the web stuff?
TomCC7
removed this pull request from stack #4048
September 10, 2026 19:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by the three-feature stack: SDK web/source packaging is in #4044; the application dependency-policy helper is in #4047.
Current review order: #4042 → #4044 → #4047. Stack: https://github.com/dimensionalOS/dimos/stack/4064
Installing DimOS as an external Git dependency currently depends on web assets from the developer checkout. Build missing assets during wheel/sdist creation and define the SDK dependency-source policy consumed by app creation.
Validation: source-build and dependency-policy tests pass; a full external SDK Git install built its own assets successfully. The source archive passes the repository packaging check.
PRD: https://linear.app/dimensional/project/dimos-developer-onboarding-v1-3df889ba9a65
Review in order: #4042 → #4043 → #4044 → #4045 → #4046 → #4047. Replaces the implementation in #4027–#4030.