Repository navigation
Fix for Install-Binary script - #307
Merged
Merged
Conversation
Hammond95
marked this pull request as draft
September 14, 2021 21:25
Hammond95
marked this pull request as ready for review
September 14, 2021 22:00
Contributor
Author
|
@databus23, @mumoshu, sorry to bother you, any chance you can give a look at my PR? Also, I would like to help maintain this project, would this be possible? |
mumoshu
approved these changes
Jan 8, 2022
mumoshu
left a comment
mumoshu
left a comment
Collaborator
There was a problem hiding this comment.
We lack comprehensive test cases to verify this doesn't break anything. But it looks good to me so let's try! Thanks for your patience and contribution
Collaborator
|
I've verified that |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script failed because of some conditions assumed true, fixed as follow:
resolves #244