Repository navigation
plugin does not install if helm is helm 3 but run from helm 2 #244
Description
The install-binary.sh script uses the helm home command which only exists in helm 3. Interestingly, if either helm 2 XOR helm 3 are installed on my system, the plugin installs fine. However if both versions of helm are on my system, and helm is actually helm 3, and helm 2 has some other name, then the plugin no longer installs for helm 2:
helm versionshows helm 3helm plugin install https://github.com/databus23/helm-diffworkshelm2 versionshows helm 2helm2 plugin install https://github.com/databus23/helm-difffails with error message thathomeis not a recognized command
At first unclear what this is about, but inspection of source code indicates the error happens because install-binary.sh calls helm home, which in the above scenario actually calls helm 3, which does not support home command (I'm guessing that helm 3's plugin install does not use that script otherwise it would fail too).
Is there a reason that $(helm home) cannot be replaced by $HELM_HOME?
Activity
stale commentedon Feb 2, 2021
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
schollii commentedon Feb 2, 2021
I'd like to keep this open. I'll submit a PR and see what happens.
stale commentedon Jun 2, 2021
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
schollii commentedon Jun 2, 2021
bump
mumoshu commentedon Jun 2, 2021
@schollii I think #270 fixed this issue. Would you mind confirming?
schollii commentedon Jun 3, 2021
It looks like it might but I have to try it to be sure. I will post result soon.
stale commentedon Sep 3, 2021
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
schollii commentedon Oct 12, 2021
Looks like #270 fixes this indeed