Skip to content

fix: in StreamService streamId was never set , with this PR , it is returned from StreamServiceInternal #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hdhayneCoveo merged 5 commits into from
Jun 9, 2023
Merged

fix: in StreamService streamId was never set , with this PR , it is returned from StreamServiceInternal #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1d1f02c
fix: in StreamService streamId was never set , with this change Strea…
hdhayneCoveo Jun 8, 2023
88cf181
remove public modifier
hdhayneCoveo Jun 8, 2023
5cfa8a6
Merge branch 'main' into BUG_FIXING
y-lakhdar Jun 9, 2023
6d518d1
merge with main
hdhayneCoveo Jun 9, 2023
fc22d21
apply code format
hdhayneCoveo Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/coveo/pushapiclient/StreamService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public StreamService(StreamEnabledSource source) {
* @throws IOException
*/
public void add(DocumentBuilder document) throws IOException, InterruptedException {
this.service.add(document);
this.streamId = this.service.add(document);
}

/**
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/com/coveo/pushapiclient/StreamServiceInternal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,12 @@ public StreamServiceInternal(
this.platformClient = platformClient;
}

public void add(DocumentBuilder document) throws IOException, InterruptedException {
public String add(DocumentBuilder document) throws IOException, InterruptedException {
if (this.streamId == null) {
this.streamId = this.getStreamId();
}
queue.add(document);
return this.streamId;
}

public HttpResponse<String> close()
Expand Down