fix: in StreamService streamId was never set , with this PR , it is returned from StreamServiceInternal - #42
Merged
Merged
Conversation
…mServiceInternal returns it to StreamService
hdhayneCoveo
requested review from
a team,
btaillon-coveo,
louis-bompart and
olamothe
and removed request for
a team
June 8, 2023 20:46
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
btaillon-coveo
approved these changes
Jun 9, 2023
y-lakhdar
added a commit
that referenced
this pull request
Jun 20, 2023
…eturned from StreamServiceInternal (#42) Co-authored-by: Yassine <ylakhdar@coveo.com>
This was referenced Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this bug was found while testing the service with the creation of sample code classes