test(uitests): finish the tab-bar rewrite for convert, settings, give, chat and discover

.claude/plans/2026-08-20-ui-test-tab-bar-rewrite.md

@@ -1,12 +1,10 @@
 # UI test rewrite for the tab-bar UI
 
 Shipping the tab-bar UI to everyone (`BetaFlags.Option.newUI` → `.shipped`) removed the
-v1 scanner chrome that the XCUITest suite navigated through. The affected tests are
-skipped via `BaseUITestCase.skipPendingTabBarRewrite(_:)` so the release can run; this
-is the map for putting them back.
-
-Grep `skipPendingTabBarRewrite` for the live list. The helper is deleted with the last
-call site.
+v1 scanner chrome that the XCUITest suite navigated through. Every affected test has
+been rewritten or dropped, and `BaseUITestCase.skipPendingTabBarRewrite(_:)` went with
+the last call site. This is the record of where each flow moved and what the v2 routes
+cost the suite.
 
 ## What moved
 
@@ -18,8 +16,11 @@ call site.
 | `scan-tips-button` | Chat tab (`app.buttons["Chat"]`) — embedded, so no `navigationBars["Tips"]` Close button |
 | `scan-discover-button` | Wallet tab → "Discover Currencies" tile (a push, not a sheet) |
 | `discover-create-currency-card` promo | Wallet tab → "Create a Currency" tile — `CurrencyDiscoveryScreen.hidesPromo` hides the card |
+| Tips intro → name → photo → tipcard (profile creation) | nothing — onboarding sets the name and the You tab draws the card. The name is editable at You → My Account → **Change Display Name**. |
 | Settings "Add Money" / "Withdraw Money" rows | Wallet tab tiles of the same name |
+| `CurrencyInfoScreen` "Transaction History" button | the **"Recent"** section header (`RecentActivitySection.onShowAll`); the rows under it are a non-interactive preview |
 | `CurrencyInfoScreen` "Buy" / "Sell" / "Give" footer | `CurrencyInfoContentV2` action tiles — **Give / Convert / Withdraw** for a currency you hold, **Get** for one you don't. No Buy, no Sell. |
+| Buy paying with reserves / Sell to Dollars | **Convert**, from either end. Open the balance you are paying *from* and convert to the one you want: token → Dollars replaces Sell, Dollars → token replaces buy-with-reserves, token → token replaces buy-with-currency. |
 
 ## Gotchas
 
@@ -28,22 +29,76 @@ call site.
   `assertMainScreenReached()` (now the Wallet tab) only holds at a tab root — pop first.
 - **The You tab's settings rows sit below the fold.** They render under the tip card, so
   scroll them into view (`scrollUpToAndTap(_:in:)`) rather than tapping blind.
-- **`GiveDiscoverGateRegressionTests` tests behavior that no longer exists.** USDF is
-  giveable now (`BetaFlags.allowsDollarsGive`), so `GiveCashGate.discoverCurrencies` is
-  unreachable and the "No Community Currencies Yet" dialog never shows. Delete the test
-  with the phase-2 teardown rather than rewriting it.
-- **`BaseUITestCase.navigateToGiveAmount()` still taps the v1 Cash button.** Its only
-  callers are skipped; rewrite it against whichever give entry the tests should cover.
+- **`GiveCashGate` has no v2 entry from a tab root.** `ScanBottomBar` — the only caller
+  that gated a *give* — renders under `if !isEmbedded`, and the Scan tab embeds
+  `ScanScreen`. The gate still fires from a chat's Send Cash (`ConversationScreen`),
+  `TipFlow`, and the give deeplink, none of which a fresh empty account can reach. So
+  both dialog regressions built on the Cash button lose their subject, and both are
+  deleted. `GiveDiscoverGateRegressionTests` doubly so, since USDF is giveable now
+  (`BetaFlags.allowsDollarsGive`) and `GiveCashGate.discoverCurrencies` is unreachable
+  either way. `GiveRegressionTests` covered the "No Balance Yet" gate: an empty account
+  has no currency card, so it cannot reach the Give tile that would raise it.
+- **The Wallet tiles are gated on funding, and a $0 account has no way around it.**
+  `WalletScreen` draws `walletTiles` only when `session.hasEverAddedMoney()`
+  (`holdsBalance || database.hasEverAddedMoney()`); an unfunded account gets the
+  new-user tutorial in their place. That gate collides with the two add-money
+  regressions, which need an empty balance by definition. The buy gate has no way out,
+  so `AddMoneyGateRegressionTests` is deleted: `flipcash://discover` reaches the same
+  destination, but `app.open` relaunches the app and a freshly created account does not
+  survive the relaunch — the app comes back on "Create a New Account" — while both
+  standing accounts hold displayable USDF, so `BuyAmountViewModel.paymentOptions` is
+  non-empty and the button reads Next. The gate itself is live, and a spent-down
+  fixture would restore the test. The creation gate survives because `shouldAddMoneyBeforeLaunch` is a *shortfall* check,
+  not a $0 check: the standing account holds money but not the launch cost
+  (`newCurrencyPurchaseAmount` + `newCurrencyFeeAmount`), so Get Started still raises the
+  prompt. That is fixture-dependent, so the test skips if the account can afford it.
+- **Currency creation has exactly two doors, both on the funded path.**
+  `.currencyCreationSummary` is pushed from the Wallet tile and from Discover's promo
+  card, which `CurrencyDiscoveryScreen.hidesPromo` hides in v2. There is no deeplink.
+- **Per-token history moved into the "Recent" header.** `CurrencyInfoContentV2` has no
+  "Transaction History" button; the header button is the only way in, and it sits below
+  the hero card and the action tiles, so it needs scrolling into view.
+- **The Access Key row is on Advanced, not My Account.** `SettingsMyAccountScreen` says
+  so in its own header doc: it keeps Access Key, Log Out and Delete Account off itself,
+  and holds only Change Display Name, Blocked, and the beta-gated Switch Accounts.
+- **Profile creation has no entry left, in either UI.** `OnboardingNameScreen` is
+  mandatory after the access key, so every account reaches the app already named. Both
+  name-less prompts — `TipsIntroScreen.start-receiving-tips-button` and the You tab's
+  `you-start-receiving-tips-button` — are gated on an empty `profile.displayName` and
+  so are unreachable from a test. On top of that, `TipsScreen(isEmbedded: true)` renders
+  `TipConversationsScreen` unconditionally, so the Chat tab never shows the intro at all.
+  The reachable name route is You → My Account → **Change Display Name**
+  (`.changeDisplayName` → `ProfileNameScreen(completion: .back)`), which pops just itself
+  and lands back on My Account, not on the tab root.
+- **The profile photo step is dead in the app, not just in v2.** `ProfileNameScreen`'s
+  `.tipcard` completion pushes straight past it — "the card omits the profile photo" —
+  so `.profilePhoto` has no caller at all. `selectFirstPhotoFromLibrary` went with its
+  last caller.
+- **The embedded Chats list has no tip-card row and no toolbar.** `isEmbedded` drops the
+  `show-my-tipcard-button` cell (the card has its own tab) and hides the navigation bar,
+  so `navigationBars["Tips"].buttons["Close"]` does not exist and every cell in the list
+  is a conversation — page objects must not skip a leading row.
 - **A wallet card opens `CurrencyInfoScreen` as an overlay, not a push.** `TokenCardStack`
   reports the tap through `onCardTap`; the wallet lifts the page over the deck with a
   close box instead of a back chevron, so there is no `navigationBars` entry to wait on.
 - **The v1 buy/sell entries are gone from an owned currency.** `CurrencyInfoContentV2`
   gates its tiles on `isOwned` (balance has displayable value), and the owned branch is
-  Give/Convert/Withdraw. Buying more of a currency you already hold has no entry point
-  there, and buy pushes `.buyCurrency(mint)` onto the stack rather than presenting the
-  `.buy` nested sheet the reserves test asserts. Deciding what the v2 equivalents should
-  assert is a product question, not a selector swap — `BuyReservesRegressionTests`,
-  `BuyWithCurrencyRegressionTests` and `CurrencySellRegressionTests` are skipped on that.
+  Give/Convert/Withdraw. The replacement for both is **Convert**, entered from the
+  balance you are paying *from* rather than the one you are acquiring — so a test buys
+  more of a currency it already holds by opening Dollars and converting into it.
+- **Convert only offers balances you already hold.** `ConvertAmountViewModel.destinationOptions`
+  is `session.balances(for:)` minus the source, so convert cannot acquire a currency the
+  account has never held — that is what **Get** (`.buyCurrency(mint)`, on an unheld
+  currency) is for. The defaults matter for tests: a non-Dollars source defaults to
+  Dollars, and a Dollars source defaults to the largest other holding, so only a
+  token→token convert has to open the picker.
+- **A finished convert lands on the Wallet, not back on the currency.**
+  `ConvertFlowDestinationView` gives the processing screen a `dismissParentContainer`
+  that calls `popToRoot()` + `dismissExpandedCard()`. Assert the Wallet root after OK.
+- **Convert is pushed, so the v1 nested-sheet dismissal regressions can't recur.**
+  `BuyReservesRegressionTests` swiped down on the processing screen to prove the `.buy`
+  sheet survived; there is no sheet in the convert stack, so that assertion was dropped
+  rather than ported.
 
 ## Rewritten so far
 
@@ -54,3 +109,35 @@ call site.
   verified-contact gate *before* "Amount to Add".
 - `WalletUsdfRowRegressionTests` — the v2 deck's cards carry `currency-row` /
   `currency-row-usdf`, so the wallet page object matches again.
+- The You-tab settings group — `AccessKeyBackupSmokeTests` (×3), `BlockedUsersSmokeTests`,
+  `ApplicationLogsRegressionTests` — enters through the You tab and scrolls to the row.
+  Access Key and Application Logs are on **Advanced**; Blocked is on **My Account**.
+  `SettingsUIScreen` lost `addMoneyButton` / `withdrawMoneyButton` with the rows.
+- The wallet money-tile group — `WithdrawSmokeTests`,
+  `WithdrawPickerEmptyRegressionTests`, `DepositSmokeTests` (×2) — enters through
+  `wallet-tile-withdraw-money` / `wallet-tile-add-money` instead of the Settings rows.
+- `GiveSmokeTests` and `CashLinkRegressionTests` — `navigateToGiveAmount()` now goes
+  Wallet → first currency card → its **Give** tile. The keypad pops itself as the bill
+  appears (`GiveScreen.onBillPresented`, when `isPushed`), so both flows end on
+  `CurrencyInfoScreen` rather than a tab root — the cash link reaches its history from
+  there without a second trip through the wallet.
+- The chat group — `BlockUnblockSmokeTests` now blocks from the Chat tab and unblocks
+  through You › My Account › Blocked; its `tearDown` unblock tapped the removed Settings
+  button, so it had been silently no-opping. `ProfileCreationSmokeTests` became
+  `DisplayNameSmokeTests`: a fresh account's card on the You tab, then a rename through
+  My Account. The intro screen and the photo step were dropped, not re-routed — neither
+  has a caller left.
+- The three buy/sell tests, rewritten as the convert routes that replaced them and
+  renamed for what they now exercise: `CurrencySellRegressionTests` →
+  `ConvertToDollarsRegressionTests`, `BuyReservesRegressionTests` →
+  `ConvertFromDollarsRegressionTests`, `BuyWithCurrencyRegressionTests` →
+  `ConvertBetweenTokensRegressionTests`. `CurrencyPickerSheet` rows gained
+  `currency-picker-row` / `currency-picker-row-usdf`; `SellConfirmationScreen` went with
+  the v1 sell sheet.
+- The discover group — `DiscoverCurrenciesSmokeTests` checks the Discover Currencies and
+  Create a Currency tiles side by side (v1 reached creation *through* Discover's promo
+  card), and the currency-creation gate moved to its own
+  `CurrencyCreationGateRegressionTests`. Both now need the standing account, because
+  both entries are Wallet tiles and the tiles are gated on funding — see below.
+  `AddMoneyGateRegressionTests`' buy gate has no fixture that can reach it, so it is
+  deleted alongside the give gates.

Flipcash/Core/Screens/Main/Currency Convert/CurrencyPickerSheet.swift

@@ -38,6 +38,14 @@ struct CurrencyPickerSheet: View {
                             row(for: balance)
                         }
                         .buttonStyle(.plain)
+                        // Dollars carries its own identifier so a test can pick
+                        // it, or any token, without depending on where balances
+                        // sort.
+                        .accessibilityIdentifier(
+                            balance.stored.mint == .usdf
+                                ? "currency-picker-row-usdf"
+                                : "currency-picker-row"
+                        )
                         .listRowInsets(EdgeInsets(top: 0, leading: 20, bottom: 0, trailing: 20))
                         .listRowBackground(Color.clear)
                         .listRowSeparator(.hidden)

FlipcashUITests/Regression/ApplicationLogsRegressionTests.swift

@@ -13,14 +13,12 @@ final class ApplicationLogsRegressionTests: BaseUITestCase {
 
     // MARK: - Tests
 
-    func testApplicationLogs_shareLogsPresentsShareSheet() throws {
-        try skipPendingTabBarRewrite("the settings list moved to the You tab; Add/Withdraw Money are Wallet tiles now")
-
+    func testApplicationLogs_shareLogsPresentsShareSheet() {
         let settings = SettingsUIScreen(app: app)
 
         assertMainScreenReached()
 
-        // Navigate: Main → Settings → Advanced Features → Application Logs
+        // Navigate: Wallet → You → Advanced → Application Logs
         settings.open(from: self)
         settings.navigateToAdvancedFeatures(from: self)
         waitAndTap(settings.applicationLogsRow)