test(uitests): finish the tab-bar rewrite for convert, settings, give, chat and discover

[bmc08gt]

Finishes the UI-test rewrite that #653 started. That PR moved the Add Money and currency flows onto the tab-bar wallet; this one covers everything still entering through the v1 scanner chrome, and retires BaseUITestCase.skipPendingTabBarRewrite(_:) with its last call site.

Nothing here changes app behaviour. The one non-test change is two accessibility identifiers on CurrencyPickerSheet rows.

Buy and Sell became Convert

CurrencyInfoContentV2 gates its action tiles on isOwned, and the owned branch is Give / Convert / Withdraw — there is no Buy and no Sell. The replacement for both is Convert, entered from the balance you are paying from rather than the one you are acquiring. So the three regressions are rewritten as the routes that replaced them, and renamed for what they now exercise:

was	is
CurrencySellRegressionTests	ConvertToDollarsRegressionTests
BuyReservesRegressionTests	ConvertFromDollarsRegressionTests
BuyWithCurrencyRegressionTests	ConvertBetweenTokensRegressionTests

Convert only offers balances the account already holds — ConvertAmountViewModel.destinationOptions is session.balances(for:) minus the source — so it cannot acquire a currency the account has never held. That is what Get is for, on an unheld currency. The defaults matter for the tests: a non-Dollars source defaults to Dollars and a Dollars source defaults to the largest other holding, so only the token→token case has to open the picker. CurrencyPickerSheet rows gained currency-picker-row / currency-picker-row-usdf for it.

A finished convert lands on the Wallet, not back on the currency: ConvertFlowDestinationView hands the processing screen a dismissParentContainer that calls popToRoot() and dismissExpandedCard().

BuyReservesRegressionTests used to swipe down on the processing screen to prove the .buy sheet survived a nested dismissal. Convert is pushed, not presented, so there is no sheet to lose — that assertion was dropped rather than ported. SellConfirmationScreen went with the v1 sell sheet.

Settings moved to the You tab

The scanner's Settings button is gone; the list is on the You tab, under the tip card, so each test opens the tab and scrolls to its row. Access Key and Application Logs are on Advanced — SettingsMyAccountScreen keeps Access Key, Log Out and Delete Account off itself and holds only Change Display Name, Blocked, and the beta-gated Switch Accounts.

Covers AccessKeyBackupSmokeTests (×3), BlockedUsersSmokeTests, ApplicationLogsRegressionTests.

Add Money and Withdraw Money are Wallet tiles

SettingsUIScreen loses both properties with the rows. WithdrawSmokeTests, WithdrawPickerEmptyRegressionTests and DepositSmokeTests (×2) enter through the tiles instead.

Give starts from a currency

navigateToGiveAmount() goes Wallet → first currency card → its Give tile, replacing the scanner's Cash button. The keypad is pushed and pops itself as the bill appears (GiveScreen.onBillPresented, when isPushed), so both callers finish on CurrencyInfoScreen rather than a tab root. GiveSmokeTests asserts that on cancel, and CashLinkRegressionTests reaches its history from there without a second trip through the wallet — that history is the "Recent" section header now, since CurrencyInfoContentV2 has no "Transaction History" button.

The balance-retry loop is gone from the helper: the Give tile is only drawn for a currency the account holds, so this path raises no gate dialog to dismiss.

Chat and profile

BlockUnblockSmokeTests opened the Tips list as a sheet off the scanner's bottom bar. Embedded as the Chat tab it has no toolbar and no leading tip-card cell, so TipsUIScreen opens app.buttons["Chat"], waits on the "Chats" title instead of show-my-tipcard-button, and treats every cell as a conversation.

Its tearDown unblock still tapped app.buttons["Settings"], so it had been silently no-opping — a run that failed after the block left the shared test account with a user blocked. It goes through You › My Account › Blocked now, with a non-asserting scroll of its own: scrollUpToAndTap would fail the teardown and mask the failure that triggered it.

ProfileCreationSmokeTests walked Tips intro → name → photo → tipcard, and none of those steps has an entry left. OnboardingNameScreen is mandatory after the access key, so no account reaches the app without a name and both name-less prompts stay gated off; ProfileNameScreen skips the photo step for every caller because the card omits the photo, so .profilePhoto has no caller at all.

DisplayNameSmokeTests replaces it with what survived: a freshly registered account lands on the You tab with a card it can share, and the name behind that card changes through My Account. The editor pops back to My Account rather than the tab root (completion: .back pops one screen) and only once SetDisplayName returns, so landing there is still the proof that the name was accepted and moderated.

Discover and currency creation are sibling tiles

v1 reached currency creation through Discover, from the promo card at the top of its list. The tab-bar UI splits them into two Wallet tiles and hides the card (CurrencyDiscoveryScreen.hidesPromo), so DiscoverCurrenciesSmokeTests checks the two entries side by side and asserts the card is gone.

Both tiles are gated on funding: WalletScreen draws walletTiles only when session.hasEverAddedMoney(), and gives an unfunded account the new-user tutorial in their place. So the test takes the standing account rather than creating a fresh one. It only navigates.

Three gate regressions lose their fixture

All three needed an account with nothing spendable, and the tab-bar UI gives such an account no door to the screen that raises the gate.

GiveDiscoverGateRegressionTests and GiveRegressionTests are deleted. ScanBottomBar was the only caller that gated a give from a tab root, and it renders under if !isEmbedded — the Scan tab embeds ScanScreen. GiveCashGate still fires from a chat's Send Cash, TipFlow and the give deeplink, none of which a fresh empty account reaches. The Discover branch is doubly gone: USDF is giveable now (BetaFlags.allowsDollarsGive), so GiveCashGate.discoverCurrencies is unreachable either way.

AddMoneyGateRegressionTests is deleted for the same reason on the buy side. The Discover tile needs hasEverAddedMoney(); flipcash://discover reaches the same destination, but app.open relaunches the app and a freshly created account comes back on "Create a New Account"; and both standing accounts hold displayable USDF, so BuyAmountViewModel.paymentOptions is non-empty and the button reads Next.

The creation gate survives, in its own CurrencyCreationGateRegressionTests on the standing account, because shouldAddMoneyBeforeLaunch is a shortfall check rather than a $0 check: the account holds money but not newCurrencyPurchaseAmount + newCurrencyFeeAmount, so Get Started still raises the prompt instead of the wizard. That depends on a balance the test doesn't control, so it skips if the account can afford the launch.

All three gates are live app code. The rewrite plan records what a spent-down fixture would restore.