Skip to content

docs(mosaic): refine agent guidance from PR reviews - #10120

Merged
austincalvelage merged 5 commits into
carp/mosaic-inventing-patternsfrom
austin/mosaic-review-guidance
Oct 7, 2026
Merged

austincalvelage merged 5 commits into
carp/mosaic-inventing-patternsfrom
austin/mosaic-review-guidance

Conversation

@austincalvelage

@austincalvelage austincalvelage commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Description

Turns recurring Mosaic PR-review findings into shared agent guidance for everyone working in the repository. Builds on #10115 with concrete implementation and verification guidance.

  • Require reuse searches and abstractions that improve readability. Share stable business rules while allowing presentation to diverge.
  • Clarify wrapper, controller, and view composition while preserving leaf controllers that receive effects through props.
  • Add concrete checks for dialog reset and reopen behavior, pending actions, failed imports, explicit clock inputs and SSR hydration, and unknown-error causes and fallback messages.
  • Keep one task-guide index in packages/mosaic/AGENTS.md. Correct styling and comment examples, qualify ARIA override behavior, and make the test example verify the active organization.

Only shared agent instructions and documentation change. Includes an empty changeset.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 43ab22c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Oct 7, 2026 8:19pm UTC
swingset Ready Ready Preview Oct 7, 2026 8:19pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 6dff0611-5edd-4c7c-8c9a-59a700253abd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Comment thread packages/mosaic/docs/models.md
@austincalvelage
austincalvelage merged commit 293ee46 into carp/mosaic-inventing-patterns Oct 7, 2026
10 checks passed
@austincalvelage
austincalvelage deleted the austin/mosaic-review-guidance branch October 7, 2026 20:21

This branch was successfully deployed

2 active deployments
Preview – swingset — 43ab22c0 Deployed Oct 7, 2026 by vercel[bot]
Preview – clerk-js-sandbox — 43ab22c0 Deployed Oct 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants