Skip to content

ci(checks): let duplicate PR runs finish #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chhoumann merged 1 commit into from
Oct 11, 2026
Merged

ci(checks): let duplicate PR runs finish #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/dependency-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ on:
permissions:
contents: read

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
cancel-in-progress: true

jobs:
dependency-review:
name: Dependency Review
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/documentation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ on:
permissions:
contents: read

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
cancel-in-progress: true

jobs:
docs:
name: Docs
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/pr-title.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ on:
permissions:
pull-requests: read

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
cancel-in-progress: true

jobs:
validate:
name: Validate PR title
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ on:
permissions:
contents: read

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
cancel-in-progress: true

jobs:
test:
name: Test
Expand Down
9 changes: 9 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,15 @@ workflow from `master`, so the PR still reports the old name. `Prepare release`
also matches the `Test` workflow by its top-level `name:`, so renaming the
workflow stops release planning without failing any check.

The `Test`, `Documentation`, `PR Title`, and `Dependency Review` workflows have
no `concurrency` block, so GitHub does not cancel their runs. Duplicate events
on one PR head, such as a reopen or an edit right after a push, start duplicate
runs of the required checks, and every run must finish. A cancelled run on the
head turns the commit's check rollup to `FAILURE`. Do not add a `concurrency`
group to these workflows. By default a group cancels a pending run when a newer
run joins it, even with `cancel-in-progress: false`. Runs for a superseded head
also finish. They cost CI minutes but block nothing.

Recovery is for the owner. Agents never dispatch release workflows. The release
stage accepts only the refs below, re-derives and re-verifies the release commit
from the PR on each, and re-running a published version verifies it and changes
Expand Down
Loading