Repository navigation
ci(checks): let duplicate PR runs finish - #381
Merged
Merged
Conversation
Deploying podnotes with
|
| Latest commit: |
fd524f6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://14041907.podnotes.pages.dev |
| Branch Preview URL: | https://ci-no-cancelled-required-che.podnotes.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Duplicate PR events currently cancel required checks on the same head, leaving the aggregate rollup at
FAILURE. Remove concurrency from Test, Docs, PR Title, and Dependency Review because native groups cannot distinguish a duplicate head from a superseded commit and still cancel pending runs withcancel-in-progress: false. Superseded runs may finish; the extra CI work is cheaper than a custom cancellation mechanism.The baseline probe measured
CLEANmerge state after the latest required checks passed, despite the failed aggregate rollup. Cancelled duplicates do not universally block the ruleset.Verification
npm run lint,npm run format:check,npm run typecheck,npm run build,npm run test(81 files, 1,263 tests), andnpm run docs:buildall pass. Actionlint 1.7.12 passes.FAILUREbaseline, thenSUCCESSon duplicate and superseded fixed heads with zero cancellations. Productionpull_request_targetstill needs a post-merge probe because GitHub reads its workflow from the default branch.Release impact
None. Release workflows, required check names, permissions, and the ruleset are unchanged.
Note
Remove workflow-level concurrency groups from 4 CI workflows
Removes the
concurrencyblocks (group +cancel-in-progress) from the Dependency Review, Documentation, PR Title, and Test workflows in.github/workflows/. Duplicate PR runs can now finish instead of cancelling each other. Documents the rationale in AGENTS.md: cancelled runs can make the commit check rollup fail, so concurrency groups should not be added to these workflows.Macroscope summarized fd524f6.