Skip to content

switch to packaging.version #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skyecas merged 3 commits into from
Aug 17, 2023
Merged

switch to packaging.version #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6604d5
switch to packagin.version
skyecas Aug 15, 2023
e5c7661
add packaging to setuptools
skyecas Aug 16, 2023
2a69727
update version
skyecas Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions maas/client/viscera/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

__all__ = ["Version"]

from distutils.version import StrictVersion
from packaging.version import Version as PackagingVersion

from . import Object, ObjectField, ObjectType


def parse_version(version):
return StrictVersion(version).version
return PackagingVersion(version).release


class VersionType(ObjectType):
Expand Down
2 changes: 1 addition & 1 deletion scripts/check-imports
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ python_standard_libs = [
'difflib',
'dircache',
'dis',
'distutils',
'dl',
'doctest',
'DocXMLRPCServer',
Expand Down Expand Up @@ -203,6 +202,7 @@ python_standard_libs = [
'optparse',
'os',
'ossaudiodev',
'packaging',
'parser',
'pathlib',
'pdb',
Expand Down
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ def read(filename):
"colorclass >= 1.2.0",
"macaroonbakery >= 1.1.3",
"oauthlib >= 1.0.3",
"packaging >= 21.3",
"pymongo >= 3.5.1", # for bson
"pytz >= 2014.10",
"PyYAML >= 3.11",
Expand Down