Skip to content

switch to packaging.version - #290

Merged
skyecas merged 3 commits into
canonical:masterfrom
skyecas:replace-distutils
Aug 17, 2023
Merged

skyecas merged 3 commits into
canonical:masterfrom
skyecas:replace-distutils

Conversation

@skyecas

@skyecas skyecas commented Aug 15, 2023

Copy link
Copy Markdown
Contributor

addresses #289: distutils.version is being deprecated soon(tm), this should replace it's occurrences in libmaas

@skyecas skyecas added the bug label Aug 15, 2023
@codecov-commenter

codecov-commenter commented Aug 17, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #290 (2a69727) into master (fd95219) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #290   +/-   ##
=======================================
  Coverage   69.16%   69.16%           
=======================================
  Files          73       73           
  Lines        5958     5958           
  Branches     1336     1336           
=======================================
  Hits         4121     4121           
  Misses       1607     1607           
  Partials      230      230           
Files Changed Coverage Δ
maas/client/viscera/version.py 87.50% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cpg1111 cpg1111 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@skyecas
skyecas merged commit 1ff28d5 into canonical:master Aug 17, 2023
@skyecas
skyecas deleted the replace-distutils branch August 17, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants