support msgpack 1.2.2 (1.4-maint) - #10219
Merged
ThomasWaldmann merged 1 commit intoAug 27, 2026
Merged
Conversation
msgpack 1.2.2 only brings bug fixes relevant to borg's usage: correct Timestamp.from_datetime for datetimes far from the epoch, reject out-of-range timestamp nanoseconds, copy ExtraData.extra out of a temporary contiguous buffer, and a new RuntimeError guard against re-entrant Unpacker.feed() (borg never feeds from inside a hook). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.4-maint #10219 +/- ##
==========================================
Coverage 82.14% 82.15%
==========================================
Files 38 38
Lines 11475 11475
Branches 1807 1807
==========================================
+ Hits 9426 9427 +1
+ Misses 1464 1463 -1
Partials 585 585 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the msgpack 1.2.2 release: bump the upper bound in
pyproject.tomland inis_supported_msgpack().No changelog entry, as 1.4-maint currently has no "not released yet" section.
The 1.2.1 -> 1.2.2 diff contains only fixes, nothing that affects how borg uses msgpack:
Timestamp.from_datetimenow uses integer timedelta arithmetic instead of the floatdatetime.timestamp()(which was off by one second far from the epoch and raisedOverflowErrorneardatetime.max)timestamp=modesExtraData.extrais copied out of the temporary contiguous buffer before that buffer is released (non-contiguous memoryview input)PyFloat_Pack4return value is checked inmsgpack_pack_floatRuntimeErrorguard against re-entrantUnpacker.feed()from a hook - borg never feeds from inside a hookUnpacker.skip()translatesRecursionErrorintoStackErrorMaster: #10218
🤖 Generated with Claude Code