Skip to content

support msgpack 1.2.2 - #10218

Merged
ThomasWaldmann merged 1 commit into
borgbackup:masterfrom
ThomasWaldmann:msgpack-1.2.2
Aug 27, 2026
Merged

support msgpack 1.2.2#10218
ThomasWaldmann merged 1 commit into
borgbackup:masterfrom
ThomasWaldmann:msgpack-1.2.2

Conversation

@ThomasWaldmann

Copy link
Copy Markdown
Member

Allow the msgpack 1.2.2 release: bump the upper bound in pyproject.toml and in is_supported_msgpack(), plus a changelog entry.

The 1.2.1 -> 1.2.2 diff contains only fixes, nothing that affects how borg uses msgpack:

  • Timestamp.from_datetime now uses integer timedelta arithmetic instead of the float datetime.timestamp() (which was off by one second far from the epoch and raised OverflowError near datetime.max)
  • out-of-range timestamp nanoseconds are rejected in all timestamp= modes
  • ExtraData.extra is copied out of the temporary contiguous buffer before that buffer is released (non-contiguous memoryview input)
  • PyFloat_Pack4 return value is checked in msgpack_pack_float
  • new RuntimeError guard against re-entrant Unpacker.feed() from a hook - borg never feeds from inside a hook
  • fallback Unpacker.skip() translates RecursionError into StackError

🤖 Generated with Claude Code

msgpack 1.2.2 only brings bug fixes relevant to borg's usage:
correct Timestamp.from_datetime for datetimes far from the epoch,
reject out-of-range timestamp nanoseconds, copy ExtraData.extra out of
a temporary contiguous buffer, and a new RuntimeError guard against
re-entrant Unpacker.feed() (borg never feeds from inside a hook).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.29%. Comparing base (2491d56) to head (0ad66ed).
⚠️ Report is 38 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10218      +/-   ##
==========================================
+ Coverage   87.20%   87.29%   +0.08%     
==========================================
  Files         102      102              
  Lines       18394    18444      +50     
  Branches     2829     2834       +5     
==========================================
+ Hits        16040    16100      +60     
+ Misses       1644     1638       -6     
+ Partials      710      706       -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@ThomasWaldmann
ThomasWaldmann merged commit 4ea08c0 into borgbackup:master Aug 27, 2026
23 checks passed
@ThomasWaldmann
ThomasWaldmann deleted the msgpack-1.2.2 branch August 27, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant