Skip to content

Revert "Fixing SamzaSQL Latency Metrics resolution (#1116)" - #1118

Merged
cameronlee314 merged 1 commit into
apache:masterfrom
cameronlee314:revert_sql_latency
Jul 29, 2019
Merged

Revert "Fixing SamzaSQL Latency Metrics resolution (#1116)"#1118
cameronlee314 merged 1 commit into
apache:masterfrom
cameronlee314:revert_sql_latency

Conversation

@cameronlee314

@cameronlee314 cameronlee314 commented Jul 29, 2019

Copy link
Copy Markdown
Contributor

This reverts commit ec536e1.

PR 1116 included some issues, which will be fixed in PR 1117:

  1. semantic change to return values of IncomingMessageEnvelope.getEventTime and IncomingMessageEnvelope.getArrivalTime (changed from millis to nanos) which are public API methods, and it will be hard to find existing usages to make sure they are updated properly
  2. usages of constructor of IncomingMessageEnvelope was not updated to handle nanos correctly in certain places (e.g. KafkaConsumerProxy)

@cameronlee314
cameronlee314 merged commit 97942d9 into apache:master Jul 29, 2019
@cameronlee314
cameronlee314 deleted the revert_sql_latency branch October 4, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prateekm prateekm prateekm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cameronlee314 @prateekm