Repository navigation
[SAMZA-2282] Fixing SamzaSQL Latency Metrics resolution - #1116
Merged
Merged
Conversation
shenodaguirguis
commented
Jul 26, 2019
shenodaguirguis
commented
Contributor
- Converting timestamps to numerical instead of text
- fixing latency resolution issue by using nanoTime resolution and reporting micro resolution latencies
shenodaguirguis
changed the title
cameronlee314
added a commit
to cameronlee314/samza
that referenced
this pull request
Jul 29, 2019
This reverts commit ec536e1.
cameronlee314
added a commit
that referenced
this pull request
Jul 29, 2019
This reverts commit ec536e1. PR 1116 included some issues, which will be fixed in PR 1117: 1) semantic change to return values of IncomingMessageEnvelope.getEventTime and IncomingMessageEnvelope.getArrivalTime (changed from millis to nanos) which are public API methods, and it will be hard to find existing usages to make sure they are updated properly, 2) usages of constructor of IncomingMessageEnvelope was not updated to handle nanos correctly in certain places (e.g. KafkaConsumerProxy)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.