Repository navigation
Move dataframe and dataframe_functon into core_integration test binary - #6697
Merged
Merged
Conversation
crepererum
approved these changes
Jun 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #6676
Closes #6682
Rationale for this change
Keeping the number of distinct test binaries down reduces disk space usage and decreases build time (see notes on #6682)
This implements a modified version of @crepererum 's suggestion from #6682 (comment)
Instead of making a dataframe specific test binary as on #6682, this PR moves the two dataframe modules so they are run as part of the new
core_intrgationbinaryThus I estimate this PR will save about 250MB of disk space on the builder
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?