Repository navigation
Minor: combine dataframe and dataframe_functions tests to save build time and builder disk space - #6682
Closed
alamb wants to merge 2 commits into
Closed
Minor: combine dataframe and dataframe_functions tests to save build time and builder disk space#6682alamb wants to merge 2 commits into
dataframe and dataframe_functions tests to save build time and builder disk space#6682alamb wants to merge 2 commits into
Conversation
alamb
changed the title
alamb
commented
Jun 15, 2023
| Ok(()) | ||
| } | ||
|
|
||
| // --------------- Begin dataframe function tests ---------------- |
Contributor
Author
There was a problem hiding this comment.
these tests are moved from one file to another and create_test_table redundancy is removed. Otherwise they are not altered
Contributor
There was a problem hiding this comment.
I suggest you put these into rust modules instead. The issue w/ disk space is NOT that they are in different files but that you have two test binaries.
File struct is:
dataframe.rs:mod dataframe; mod dataframe_functions;
dataframe/dataframe.rsdataframe/dataframe_functions.rs
Contributor
Author
There was a problem hiding this comment.
This is a good idea -- I implemented a modified version of this suggestion in #6697
alamb
changed the title
dataframe and dataframe_functions tests to save build time and builder disk space
Contributor
Author
|
I verified that the moved tests still run. For example:
|
This was referenced Jun 15, 2023
Merged
This was referenced Jun 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #6676
Rationale for this change
We are running into builder space problems so reducing the space needed to run
cargo testis required. Also it would be nice to get faster CI runs.Locally for me on my mac, it seems like each test binary takes a few seconds to compile and 100+MB of disk space. Thus combining them into fewer larger tests (so we have fewer binaries) will be an improvement
What changes are included in this PR?
Combine
dataframeanddataframe_functiontests:Are these changes tested?
Yes by existing CI
Are there any user-facing changes?
No -- this is development process
Measurements
dataframe_functions (126MB)
dataframe (pre-PR) (133MB)
dataframe (with this PR) (134MB)
By combining them, the result is 134 MB, A savings of 125MB.
Admittedly these measurements are on my mac, but I think they will hold generally