Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

Update Build Optimizer to use TS 2.6 - #299

Merged
filipesilva merged 3 commits into
angular:masterfrom
clydin:bo-ts2.6
Nov 27, 2017
Merged

filipesilva merged 3 commits into
angular:masterfrom
clydin:bo-ts2.6

Conversation

@clydin

@clydin clydin commented Nov 25, 2017

Copy link
Copy Markdown
Member

No description provided.

filipesilva
filipesilva previously approved these changes Nov 25, 2017

@filipesilva filipesilva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM but at the moment the only the integration tests will really use 2.6. Unit tests will still use 2.4.

I think we should be ok to update devkit in general to use 2.6 though. Build Optimizer is the only lib inside with a runtime dependency on typescript.

@clydin @hansl WDYT?

@filipesilva filipesilva self-assigned this Nov 25, 2017
@filipesilva

filipesilva commented Nov 25, 2017 •

Copy link
Copy Markdown
Contributor

This PR should fix angular/angular-cli#7110, angular/angular-cli#8615.

@filipesilva

Copy link
Copy Markdown
Contributor

Devkit TS 2.6 update is being done separately in #300,

@filipesilva
filipesilva merged commit fbd4d41 into angular:master Nov 27, 2017
@clydin
clydin deleted the bo-ts2.6 branch November 27, 2017 13:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants