--build-optimizer errors "Cannot read property 'type' of undefined" #7110

Activity

1. dherges commented on Jul 25, 2017

   

   dherges

   on Jul 25, 2017

   Last edited by dherges

   Author

   More actions

   After #7105, I have now a fresh working copy at dherges/ng-cli-build-optimizer-issue7110.

   I will try to reproduce the issue there and then give an update.
2. rtm commented on Jul 27, 2017

   

   rtm

   on Jul 27, 2017

   More actions

   I had a similar problem and solved it by replacing import { Observable } from 'rxjs/Rx'; with import { Observable } from 'rxjs/Observable';.

   👍React with 👍60Reacted by Hanfrey, Jonathan Cammisuli, Chris Marx, Alfonso Andrés López Molina, Guillaume Nury, John Kiragu, Steve Todorov, coffeetea-synchestra, Ross, javadmjt and 50 more

   👎React with 👎2Reacted by suresh2018 and 麻辣小面瘫

   😕React with 😕4Reacted by Joniras, kurcheni, orlando2116 and David Leblay

   ❤️React with ❤️8Reacted by coffeetea-synchestra, javadmjt, michaeldev6, Salvador Subarroca, Omkar Sutar, Pratap A K, Trevor Suna and David Leblay
3. dherges commented on Jul 27, 2017

   

   dherges

   on Jul 27, 2017

   Author

   More actions

   @rtm Yep, thanks! That's the cause!

   @filipesilva Here's the repro: https://github.com/dherges/ng-cli-build-optimizer-issue7110/commit/4a19a56da0e9a77072395f0f70de3b28b54dc1a7

   @Hanfrey FYI ... Fehler erkannt, Fehler gebannt! 🐎
4. filipesilva commented on Jul 28, 2017

   

   filipesilva

   on Jul 28, 2017

   Contributor

   More actions

   This shouldn't happen, and I think it's the same as angular/devkit#51. Will investigate.
5. filipesilva

   self-assigned this

   on Jul 28, 2017
6. filipesilva

   added

   P1Impacts a large percentage of users; if a workaround exists it is partial or overly painfulImpacts a large percentage of users; if a workaround exists it is partial or overly painful

   effort2: medium (days)

   type: bug/fix

   freq3: high

   severity3: broken

   feature: build-optimizer

   on Jul 28, 2017
7. chriszrc commented on Jul 31, 2017

   

   chriszrc

   on Jul 31, 2017

   More actions

   Hi,

   So are you saying you could still import the entire rxjs library:

   import { Observable } from 'rxjs/Rx';

   But still see tree-shaking and just get what you need? Would certainly be less verbose than having to import all the different operators individually given the alternative import
8. slubowsky commented on Jul 31, 2017

   

   slubowsky

   on Jul 31, 2017

   More actions

   Im getting same issue - but dont think the import is "mis-aligned". Im using a 3rd party library which imports Observable bindCallback like this:
   import 'rxjs/add/observable/bindCallback';

   and then my build results in:

   ERROR in ./node_modules/rxjs/observable/BoundCallbackObservable.js
   Module build failed: TypeError: Cannot read property 'type' of undefined
       at Object.getEffectiveTypeAnnotationNode (C:\dev\my-app\node_modules\typescript\lib\typescript.js:9341:17)
       at assignContextualParameterTypes (C:\dev\my-app\node_modules\typescript\lib\typescript.js:41652:25)
       at checkFunctionExpressionOrObjectLiteralMethod (C:\dev\my-app\node_modules\typescript\lib\typescript.js:41948:29)
       at checkExpressionWorker (C:\dev\my-app\node_modules\typescript\lib\typescript.js:42959:28)
       at checkExpression (C:\dev\my-app\node_modules\typescript\lib\typescript.js:42898:42)
       at checkExpressionCached (C:\dev\my-app\node_modules\typescript\lib\typescript.js:42779:38)
       at checkReturnStatement (C:\dev\my-app\node_modules\typescript\lib\typescript.js:45418:54)
       at checkSourceElement (C:\dev\my-app\node_modules\typescript\lib\typescript.js:46763:28)
       at Object.forEach (C:\dev\my-app\node_modules\typescript\lib\typescript.js:1506:30)
       at checkBlock (C:\dev\my-app\node_modules\typescript\lib\typescript.js:44563:16)
       at checkSourceElement (C:\dev\my-app\node_modules\typescript\lib\typescript.js:46742:28)
       at checkFunctionExpressionOrObjectLiteralMethodDeferred (C:\dev\my-app\node_modules\typescript\lib\typescript.js:41990:21)
       at checkDeferredNodes (C:\dev\my-app\node_modules\typescript\lib\typescript.js:46828:25)
       at checkSourceFileWorker (C:\dev\my-app\node_modules\typescript\lib\typescript.js:46863:17)
       at checkSourceFile (C:\dev\my-app\node_modules\typescript\lib\typescript.js:46842:13)
       at Object.forEach (C:\dev\my-app\node_modules\typescript\lib\typescript.js:1506:30)
    @ ./node_modules/rxjs/observable/bindCallback.js 2:32-68
    @ ./node_modules/rxjs/add/observable/bindCallback.js
    @ ./node_modules/ng2-adal/services/adal.service.js
    @ ./src/$$_gendir/app/app.module.ngfactory.ts
    @ ./src/main.ts
    @ multi ./src/main.ts
   

   👍React with 👍7Reacted by bertrandg, Ryan Rizzo, Daniel Ostrovsky, Kevin Preller, CalvinDale, John King and Artem Arkhipov
9. filipesilva

   added a commit that references this issue on Aug 3, 2017

   fix(@angular/cli): update build-optimizer

   ...

   This issue will close once commit 7e31be6 is merged into the 'master' branch.

   7e31be6
10. hansl

    closed this as completedin #7262on Aug 3, 2017
11. 84 remaining items

    Load more

12. filipesilva commented on Nov 25, 2017

    

    filipesilva

    on Nov 25, 2017

    Contributor

    More actions

    angular/devkit#299 should fix this.
13. filipesilva commented on Nov 27, 2017

    

    filipesilva

    on Nov 27, 2017

    Contributor

    More actions

    Fixed by angular/devkit#299, will be out on the next release.

    👍React with 👍7Reacted by Lennart Hoffmann, Eduard Deza, Balázs Rostás, William Grasel, danielGz, Alexey Bolshevich and ralshammrei
14. filipesilva

    closed this as completedon Nov 27, 2017
15. patocardo commented on Jan 19, 2018

    

    patocardo

    on Jan 19, 2018

    Last edited by patocardo

    More actions

    I have the same problem and I couldn't solve it. In my case, it was caused by the use of
    import { BehaviorSubject } from 'rxjs/Rx';
    I removed it and programmed my own subject class
16. mbark commented on Jan 22, 2018

    

    mbark

    on Jan 22, 2018

    More actions

    @patocardo Did you try import { BehaviorSubject } from 'rxjs/BehaviorSubject';? That works fine for me.
17. patocardo commented on Jan 22, 2018

    

    patocardo

    on Jan 22, 2018

    Last edited by patocardo

    More actions

    @mbark, thanks to the poor documentation, I didn't know of that alternative source. I'll try it.
    By the way import { BehaviorSubject } from 'rxjs/Rx'; worked fine in development, the problem only appeared online.
    Thank you for the advice
18. fredgate commented on Jan 23, 2018

    

    fredgate

    on Jan 23, 2018

    More actions

    You can configure TSLint to warn when there are imports like 'rxjs/Rx'. It avoids to meet problem when you use AOT instead of JIT.
19. dond2clouds

    added a commit that references this issue on Apr 23, 2018

    fix(@angular/cli): update build-optimizer

    ...

    This issue will close once commit d8d4e89 is merged into the 'master' branch.

    d8d4e89
20. brobert6 commented on Apr 27, 2018

    

    brobert6

    on Apr 27, 2018

    More actions

    For me
    import 'rxjs/Rx';
    caused the problem. Specified the exact package that I want to import and it worked for me:
    import 'rxjs/Rx';
21. vytautas-pranskunas- commented on May 8, 2018

    

    vytautas-pranskunas-

    on May 8, 2018

    More actions

    @jsubiratsgirbau i do not have problems importing Observable but there are problems in RXJS node_mdules in rxjs itself
22. mateosantosdev commented on Sep 11, 2018

    

    mateosantosdev

    on Sep 11, 2018

    More actions

    I've solved it installing typescript@2.6.1

    👍React with 👍1Reacted by ralshammrei
23. angular-automatic-lock-bot commented on Sep 8, 2019

    

    angular-automatic-lock-botbot

    on Sep 8, 2019

    More actions

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    _{This action has been performed automatically by a bot.}
24. angular-automatic-lock-bot

    locked and limited conversation to collaborators on Sep 8, 2019
25. clydin

    removed their assignment

    on Jun 28, 2022
26. mostafaibr

    added a commit that references this issue on May 29, 2026

    fix(@angular/cli): update build-optimizer

    ...

    This issue will close once commit d700c0e is merged into the 'master' branch.

    d700c0e