Collapse synced issue bodies to title + tasks by default - #153
Merged
Merged
Conversation
Deploying specsync with
|
| Latest commit: |
fe4de2f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8294799f.specsync.pages.dev |
| Branch Preview URL: | https://feat-152-tighten-synced-issu.specsync.pages.dev |
WorkItemFor now wraps Proposal, Original ask, Design notes, and Discoveries in native <details> blocks (collapsed by default in GitHub's UI), keeps Tasks/Plan changes/dependency sections visible, and strips the proposal's redundant leading H1. splitBody parses the new <!-- specsync:section=X --> markers first, falling back to the legacy bare-heading match for issues not yet re-synced. Extends the change-body-composition capability shipped by sync-design-notes (v0.13.0) — this does not touch its section-ordering or overflow-to-comment behavior. github.go's designNotesSection now calls the same wrapSection helper WorkItemFor uses, so the two can't drift out of byte-for-byte sync (wrapping Design notes without this would have silently broken the overflow-to-comment string match).
androidand
force-pushed
the
feat/152-tighten-synced-issue-bodies
branch
from
September 3, 2026 09:55
b7b294b to
fe4de2f
Compare
This was referenced Sep 3, 2026
androidand
added a commit
that referenced
this pull request
Sep 3, 2026
Closes #155 `WorkItemFor` renders `## Tasks` then pastes `tasks.md` verbatim; every tasks.md in this repo (and presumably most, by convention) opens with its own `# Tasks` H1, so every synced issue showed the heading twice. Same fix pattern as the Proposal section's redundant H1 — reuses `stripLeadingH1`. Found by inspection on issue #154 (the demo for #153, still open for review).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #152
WorkItemForwraps Proposal, Original ask, Design notes, and Discoveries in native<details>blocks (collapsed by default), keeps Tasks/Plan changes/dependency sections visible, and strips the proposal's redundant leading H1.splitBodyparses the new<!-- specsync:section=X -->markers first, falling back to the legacy bare-heading match so issues not yet re-synced still pull correctly.change-body-compositioncapability shipped bysync-design-notes(v0.13.0) — does not touch its section-ordering or overflow-to-comment behavior.github.go'sdesignNotesSectionnow calls the samewrapSectionhelperWorkItemForuses, so the two can't drift out of sync (wrapping Design notes without this would have silently broken the overflow-to-comment string match).Tests: full suite passes; one pre-existing, environment-specific test (branch-name-pattern-dependent) fails only when run from a worktree whose branch literally matches
feat/<n>-*, unrelated to this change.Correction note: this branch was originally built against a local
mainthat was 13 commits stale and didn't yet havesync-design-notes's real implementation (shipped in v0.13.0, archived 2026-08-27). An earlier version of this PR incorrectly "fixed" issue #139 by reverting its already-correct, already-shipped task checklist to unchecked — that was caught and reverted directly on #139 (restored to closed/completed, all 9 tasks checked, no lasting effect), and this branch has been rebased onto the real main and force-pushed with the corrected implementation (Design notes now collapses too, and the overflow mechanism is verified intact).